From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22780 invoked by alias); 5 Sep 2008 00:12:59 -0000 Received: (qmail 22772 invoked by uid 22791); 5 Sep 2008 00:12:59 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 Sep 2008 00:12:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 836672A96D7; Thu, 4 Sep 2008 20:12:16 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id JajHe1HeMPlF; Thu, 4 Sep 2008 20:12:16 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4C60E2A96B3; Thu, 4 Sep 2008 20:12:16 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 074D8E7ACD; Fri, 5 Sep 2008 02:12:13 +0200 (CEST) Date: Fri, 05 Sep 2008 00:12:00 -0000 From: Joel Brobecker To: Thiago Jung Bauermann Cc: gdb-patches ml Subject: Re: [rfc] add ppc testcase to test fpscr Message-ID: <20080905001213.GB26618@adacore.com> References: <1219360611.8989.6.camel@localhost.localdomain> <20080821233115.GA1239@caradoc.them.org> <1219362081.29526.2.camel@localhost.localdomain> <20080822024659.GA12951@caradoc.them.org> <1219428669.8167.2.camel@localhost.localdomain> <20080902215458.GB25623@caradoc.them.org> <1220472745.9671.13.camel@localhost.localdomain> <20080903210054.GA8670@caradoc.them.org> <1220491492.9671.17.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1220491492.9671.17.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00085.txt.bz2 > 2008-09-03 Thiago Jung Bauermann > > * gdb.arch/ppc-fp.exp: New file. > * gdb.arch/ppc-fp.c: New file. This looks good to me. Just a question: On a couple of occasions, you use the "verbose" routine, and then call it again with the same argument, except for the -log: > + verbose "Skipping powerpc floating point register tests." > + verbose -log "Skipping powerpc floating point register tests." I searched throughout the gdb.base directory, and I found only uses of verbose without -log. In testsuite/lib, I saw uses of both forms, but never at the same time... -- Joel