From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 842 invoked by alias); 4 Sep 2008 21:04:40 -0000 Received: (qmail 833 invoked by uid 22791); 4 Sep 2008 21:04:39 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Sep 2008 21:04:00 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 478029841A; Thu, 4 Sep 2008 21:03:58 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 2A27D98417; Thu, 4 Sep 2008 21:03:58 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KbLzh-0007EE-E3; Thu, 04 Sep 2008 17:03:57 -0400 Date: Thu, 04 Sep 2008 21:04:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [RFA] gdb_continue_to_breakpoint Message-ID: <20080904210357.GA27480@caradoc.them.org> Mail-Followup-To: Michael Snyder , "gdb-patches@sourceware.org" References: <48C04A98.3020508@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48C04A98.3020508@vmware.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00074.txt.bz2 On Thu, Sep 04, 2008 at 01:52:40PM -0700, Michael Snyder wrote: > This one-line change affects two changes that make > gdb_continue_to_breakpoint more useful. > > 1) If we accept "Breakpoint in" as well as "Breakpoint at", > then it will work for non-debug functions. > > 2) If we accept trailing text after the $location_pattern, > then we are not forced to include a location pattern that > takes us up to the end of the line. > > 2008-09-04 Michael Snyder > > * lib/gdb.exp (gdb_continue_to_breakpoint): Accept "in" as well > as "at" (for non-debug functions such as _start). Also accept > trailing text after $location_pattern. I dunno - when we get symbol handling confused, e.g. we can find a minsym but not the full symbol, we tend to get the wrong output from breakpoint messages. For the second part can you just put the .* at appropriate callers? -- Daniel Jacobowitz CodeSourcery