From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4694 invoked by alias); 3 Sep 2008 17:30:57 -0000 Received: (qmail 4680 invoked by uid 22791); 3 Sep 2008 17:30:55 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 03 Sep 2008 17:28:21 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0BB4798417; Wed, 3 Sep 2008 17:28:19 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id C21909809F; Wed, 3 Sep 2008 17:28:18 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Kaw9R-0007Pc-Ra; Wed, 03 Sep 2008 13:28:17 -0400 Date: Wed, 03 Sep 2008 17:30:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: Michael Snyder , angela@releasedominatrix.com, gdb-patches@sourceware.org Subject: Re: patch to send telnet BREAK for remote-over-tcp Message-ID: <20080903172817.GA28476@caradoc.them.org> Mail-Followup-To: Michael Snyder , Michael Snyder , angela@releasedominatrix.com, gdb-patches@sourceware.org References: <20080829225247.92696FE88A@dzur.releasedominatrix.com> <1220416529.3389.2.camel@localhost.localdomain> <20080903131207.GA8151@caradoc.them.org> <48BEC576.3010802@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48BEC576.3010802@vmware.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00048.txt.bz2 On Wed, Sep 03, 2008 at 10:12:22AM -0700, Michael Snyder wrote: > Daniel Jacobowitz wrote: >> On Tue, Sep 02, 2008 at 09:35:29PM -0700, Michael Snyder wrote: >>> I think this looks right, but I'd love to get another opinion. >>> >>> Daniel? Anybody? >> >> It seems fine (aside from the parenthesis formatting :-P), though I >> think it would be much more useful if added to the manual. > > OK, since I don't know if Angela has write privs, I'll fix > the parens and check it in later today. > > Should this change be propagated to ser-mingw.c? It shares > some code with this module but makes up its own serial_ops > struct. > > If not, I'll just make the new function a static, shall I? Yes, it should be used by tcp connections from mingw hosts too. -- Daniel Jacobowitz CodeSourcery