From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2627 invoked by alias); 2 Sep 2008 23:53:45 -0000 Received: (qmail 2613 invoked by uid 22791); 2 Sep 2008 23:53:44 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 02 Sep 2008 23:53:01 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id m82Nq7Ch342886 for ; Tue, 2 Sep 2008 23:52:07 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m82Nq7Z33616782 for ; Wed, 3 Sep 2008 01:52:07 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m82Nq4WA014616 for ; Wed, 3 Sep 2008 01:52:04 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m82Nq4UG014613; Wed, 3 Sep 2008 01:52:04 +0200 Message-Id: <200809022352.m82Nq4UG014613@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 3 Sep 2008 01:52:04 +0200 Subject: Re: [rfc][23/37] Eliminate builtin_type_ macros: Platform-neutral types for internal variables To: drow@false.org Date: Tue, 02 Sep 2008 23:53:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <200809022154.m82LsF4v015969@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at Sep 02, 2008 11:54:15 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00041.txt.bz2 > Daniel Jacobowitz wrote: > > On Sun, Aug 31, 2008 at 07:51:08PM +0200, Ulrich Weigand wrote: > > > One problem is the $_ variable, which holds a pointer value. To > > > allow using a platform-neutral type for this, I'm introducing a > > > new platform-neutral pointer type builtin_type_void_ptr. The > > > lenght of this type is chosen so that it can hold every CORE_ADDR > > > value. > > > > I don't think this is a good idea. Target-specific code should not be > > required to correctly handle jumbo pointers, e.g. in "(gdb) print > > foo ($_)". In a command function, we must already have some idea of > > what the associated architecture is (e.g. to initialize the > > architecture used by the expression evaluator); why not use that? > > I guess that would mean current_gdbarch for now. Like below. Once we eliminate current_gdbarch in command functions, those new instances introduces below can go away again ... Bye, Ulrich ChangeLog: * defs.h (struct gdbarch): Add forward declaration. (set_next_address): Add GDBARCH argument. * printcmd.c (set_next_address): Use it to find pointer type. * breakpoint.c (breakpoint_1): Update call. * source.c (line_info): Likewise. * findcmd.c (find_command): Use current_gdbarch to find pointer type. * breakpoint.c (set_breakpoint_count): Use platform-neutral types for internal variable values. * infrun.c (handle_inferior_event): Likewise. * source.c (forward_search_command, reverse_search_command): Likewise. * tracepoint.c (set_tracepoint_count, set_traceframe_num, set_tracepoint_num, set_traceframe_context): Likewise. Index: gdb-head/gdb/breakpoint.c =================================================================== --- gdb-head.orig/gdb/breakpoint.c +++ gdb-head/gdb/breakpoint.c @@ -401,7 +401,7 @@ set_breakpoint_count (int num) { breakpoint_count = num; set_internalvar (lookup_internalvar ("bpnum"), - value_from_longest (builtin_type_int, (LONGEST) num)); + value_from_longest (builtin_type_int32, (LONGEST) num)); } /* Used in run_command to zero the hit count when a new run starts. */ @@ -4017,7 +4017,7 @@ breakpoint_1 (int bnum, int allflag) /* Compare against (CORE_ADDR)-1 in case some compiler decides that a comparison of an unsigned with -1 is always false. */ if (last_addr != (CORE_ADDR) -1 && !server_command) - set_next_address (last_addr); + set_next_address (current_gdbarch, last_addr); } /* FIXME? Should this be moved up so that it is only called when Index: gdb-head/gdb/findcmd.c =================================================================== --- gdb-head.orig/gdb/findcmd.c +++ gdb-head/gdb/findcmd.c @@ -292,13 +292,14 @@ find_command (char *args, int from_tty) /* Record and print the results. */ set_internalvar (lookup_internalvar ("numfound"), - value_from_longest (builtin_type_int, + value_from_longest (builtin_type_int32, (LONGEST) found_count)); if (found_count > 0) { + struct gdbarch *gdbarch = current_gdbarch; + struct type *ptr_type = builtin_type (gdbarch)->builtin_data_ptr; set_internalvar (lookup_internalvar ("_"), - value_from_pointer (builtin_type_void_data_ptr, - last_found_addr)); + value_from_pointer (ptr_type, last_found_addr)); } if (found_count == 0) Index: gdb-head/gdb/infrun.c =================================================================== --- gdb-head.orig/gdb/infrun.c +++ gdb-head/gdb/infrun.c @@ -2017,7 +2017,7 @@ handle_inferior_event (struct execution_ /* Record the exit code in the convenience variable $_exitcode, so that the user can inspect this again later. */ set_internalvar (lookup_internalvar ("_exitcode"), - value_from_longest (builtin_type_int, + value_from_longest (builtin_type_int32, (LONGEST) ecs->ws.value.integer)); gdb_flush (gdb_stdout); target_mourn_inferior (); Index: gdb-head/gdb/printcmd.c =================================================================== --- gdb-head.orig/gdb/printcmd.c +++ gdb-head/gdb/printcmd.c @@ -503,13 +503,15 @@ print_scalar_formatted (const void *vala The `info lines' command uses this. */ void -set_next_address (CORE_ADDR addr) +set_next_address (struct gdbarch *gdbarch, CORE_ADDR addr) { + struct type *ptr_type = builtin_type (gdbarch)->builtin_data_ptr; + next_address = addr; /* Make address available to the user as $_. */ set_internalvar (lookup_internalvar ("_"), - value_from_pointer (builtin_type_void_data_ptr, addr)); + value_from_pointer (ptr_type, addr)); } /* Optionally print address ADDR symbolically as on STREAM, Index: gdb-head/gdb/source.c =================================================================== --- gdb-head.orig/gdb/source.c +++ gdb-head/gdb/source.c @@ -1511,7 +1511,7 @@ line_info (char *arg, int from_tty) } /* x/i should display this line's code. */ - set_next_address (start_pc); + set_next_address (current_gdbarch, start_pc); /* Repeating "info line" should do the following line. */ last_line_listed = sal.line + 1; @@ -1614,7 +1614,7 @@ forward_search_command (char *regex, int fclose (stream); print_source_lines (current_source_symtab, line, line + 1, 0); set_internalvar (lookup_internalvar ("_"), - value_from_longest (builtin_type_int, + value_from_longest (builtin_type_int32, (LONGEST) line)); current_source_line = max (line - lines_to_list / 2, 1); return; @@ -1696,7 +1696,7 @@ reverse_search_command (char *regex, int fclose (stream); print_source_lines (current_source_symtab, line, line + 1, 0); set_internalvar (lookup_internalvar ("_"), - value_from_longest (builtin_type_int, + value_from_longest (builtin_type_int32, (LONGEST) line)); current_source_line = max (line - lines_to_list / 2, 1); return; Index: gdb-head/gdb/tracepoint.c =================================================================== --- gdb-head.orig/gdb/tracepoint.c +++ gdb-head/gdb/tracepoint.c @@ -220,7 +220,7 @@ set_tracepoint_count (int num) { tracepoint_count = num; set_internalvar (lookup_internalvar ("tpnum"), - value_from_longest (builtin_type_int, (LONGEST) num)); + value_from_longest (builtin_type_int32, (LONGEST) num)); } /* Set traceframe number to NUM. */ @@ -229,7 +229,7 @@ set_traceframe_num (int num) { traceframe_number = num; set_internalvar (lookup_internalvar ("trace_frame"), - value_from_longest (builtin_type_int, (LONGEST) num)); + value_from_longest (builtin_type_int32, (LONGEST) num)); } /* Set tracepoint number to NUM. */ @@ -238,8 +238,7 @@ set_tracepoint_num (int num) { tracepoint_number = num; set_internalvar (lookup_internalvar ("tracepoint"), - value_from_longest (builtin_type_int, - (LONGEST) num)); + value_from_longest (builtin_type_int32, (LONGEST) num)); } /* Set externally visible debug variables for querying/printing @@ -252,23 +251,19 @@ set_traceframe_context (CORE_ADDR trace_ static struct type *func_range, *file_range; struct value *func_val; struct value *file_val; - static struct type *charstar; int len; - if (charstar == (struct type *) NULL) - charstar = lookup_pointer_type (builtin_type_char); - if (trace_pc == -1) /* Cease debugging any trace buffers. */ { traceframe_fun = 0; traceframe_sal.pc = traceframe_sal.line = 0; traceframe_sal.symtab = NULL; set_internalvar (lookup_internalvar ("trace_func"), - value_from_pointer (charstar, (LONGEST) 0)); + allocate_value (builtin_type_void)); set_internalvar (lookup_internalvar ("trace_file"), - value_from_pointer (charstar, (LONGEST) 0)); + allocate_value (builtin_type_void)); set_internalvar (lookup_internalvar ("trace_line"), - value_from_longest (builtin_type_int, + value_from_longest (builtin_type_int32, (LONGEST) - 1)); return; } @@ -280,7 +275,7 @@ set_traceframe_context (CORE_ADDR trace_ /* Save linenumber as "$trace_line", a debugger variable visible to users. */ set_internalvar (lookup_internalvar ("trace_line"), - value_from_longest (builtin_type_int, + value_from_longest (builtin_type_int32, (LONGEST) traceframe_sal.line)); /* Save func name as "$trace_func", a debugger variable visible to @@ -288,14 +283,14 @@ set_traceframe_context (CORE_ADDR trace_ if (traceframe_fun == NULL || SYMBOL_LINKAGE_NAME (traceframe_fun) == NULL) set_internalvar (lookup_internalvar ("trace_func"), - value_from_pointer (charstar, (LONGEST) 0)); + allocate_value (builtin_type_void)); else { len = strlen (SYMBOL_LINKAGE_NAME (traceframe_fun)); func_range = create_range_type (func_range, - builtin_type_int, 0, len - 1); + builtin_type_int32, 0, len - 1); func_string = create_array_type (func_string, - builtin_type_char, func_range); + builtin_type_true_char, func_range); func_val = allocate_value (func_string); deprecated_set_value_type (func_val, func_string); memcpy (value_contents_raw (func_val), @@ -310,14 +305,14 @@ set_traceframe_context (CORE_ADDR trace_ if (traceframe_sal.symtab == NULL || traceframe_sal.symtab->filename == NULL) set_internalvar (lookup_internalvar ("trace_file"), - value_from_pointer (charstar, (LONGEST) 0)); + allocate_value (builtin_type_void)); else { len = strlen (traceframe_sal.symtab->filename); file_range = create_range_type (file_range, - builtin_type_int, 0, len - 1); + builtin_type_int32, 0, len - 1); file_string = create_array_type (file_string, - builtin_type_char, file_range); + builtin_type_true_char, file_range); file_val = allocate_value (file_string); deprecated_set_value_type (file_val, file_string); memcpy (value_contents_raw (file_val), Index: gdb-head/gdb/defs.h =================================================================== --- gdb-head.orig/gdb/defs.h +++ gdb-head/gdb/defs.h @@ -298,6 +298,7 @@ struct cleanup struct symtab; struct breakpoint; struct frame_info; +struct gdbarch; /* From utils.c */ @@ -570,7 +571,7 @@ extern int info_verbose; /* From printcmd.c */ -extern void set_next_address (CORE_ADDR); +extern void set_next_address (struct gdbarch *, CORE_ADDR); extern void print_address_symbolic (CORE_ADDR, struct ui_file *, int, char *); -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com