From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30399 invoked by alias); 2 Sep 2008 23:46:43 -0000 Received: (qmail 30390 invoked by uid 22791); 2 Sep 2008 23:46:43 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 02 Sep 2008 23:45:57 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id CD1DA98418; Tue, 2 Sep 2008 23:45:55 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 9737E981E8; Tue, 2 Sep 2008 23:45:55 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KafZK-0008LO-Ug; Tue, 02 Sep 2008 19:45:54 -0400 Date: Tue, 02 Sep 2008 23:46:00 -0000 From: Daniel Jacobowitz To: Thiago Jung Bauermann Cc: Joel Brobecker , gdb-patches ml Subject: Re: [rfc] add ppc testcase to test fpscr Message-ID: <20080902234554.GC31087@caradoc.them.org> Mail-Followup-To: Thiago Jung Bauermann , Joel Brobecker , gdb-patches ml References: <1219360611.8989.6.camel@localhost.localdomain> <20080821233115.GA1239@caradoc.them.org> <1219362081.29526.2.camel@localhost.localdomain> <20080822024659.GA12951@caradoc.them.org> <1219428669.8167.2.camel@localhost.localdomain> <20080902213949.GH3774@adacore.com> <1220398310.4204.22.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1220398310.4204.22.camel@localhost.localdomain> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00039.txt.bz2 On Tue, Sep 02, 2008 at 08:31:50PM -0300, Thiago Jung Bauermann wrote: > > Looks OK to me, but I'm really wonderng why you added a '\r' at > > the end of the expected output in our gdb_test calls. > > That was the closest I could think of to an EOL marker. Using '$' is not > an option, I believe. You don't need an EOL marker; gdb_test adds \r\n after the supplied pattern. > > > +#include > > > > Is the use of stdio necessary in this case. If you can do without, > > then this would allow us to run this testcase in the bareboard case > > (powerpc-elf). Not strictly necessary, but nice to have... > > I added the printf calls just to make sure GCC doesn't make the 'result' > variable vanish. Maybe that's not necessary, since the asm blocks > mention result as an output variable? Or maybe GCC would also nuke the > asm blocks instead, seeing that they serve no useful purpose if 'result' > is also not used? I don't know. GCC won't eliminate user variables at -O0. If you want the test to work with optimization, or with non-GCC compilers, try making result a volatile global. -- Daniel Jacobowitz CodeSourcery