From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-58311-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3961 invoked by alias); 2 Sep 2008 21:02:26 -0000
Received: (qmail 3952 invoked by uid 22791); 2 Sep 2008 21:02:26 -0000
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 02 Sep 2008 21:01:51 +0000
Received: from localhost (localhost.localdomain [127.0.0.1]) 	by filtered-rock.gnat.com (Postfix) with ESMTP id E9F142A972F; 	Tue,  2 Sep 2008 17:01:49 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1]) 	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) 	with LMTP id ZpQeBWB5vqsS; Tue,  2 Sep 2008 17:01:49 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) 	by rock.gnat.com (Postfix) with ESMTP id A8E562A972C; 	Tue,  2 Sep 2008 17:01:49 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000) 	id C3D59E7ACD; Tue,  2 Sep 2008 23:01:46 +0200 (CEST)
Date: Tue, 02 Sep 2008 21:02:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Jerome Guitton <guitton@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/testsuite] stack check
Message-ID: <20080902210146.GC3774@adacore.com>
References: <20080901170203.GB226@adacore.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080901170203.GB226@adacore.com>
User-Agent: Mutt/1.4.2.2i
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-09/txt/msg00022.txt.bz2

> 2008-09-01  Jerome Guitton  <guitton@adacore.com>
> 
> 	* (stack-checking.c, stack-checking.exp): New testcase.

OK, except for a little nit: You forgot to add a copyright header
in the C file...

Also:

> if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [concat debug optimize=-fstack-check nowarnings]] != "" } {

I would think that the "optimize" flag was only meant to force a certain
optimization level.  Perhaps you should use additional_flags instead.

-- 
Joel