From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25597 invoked by alias); 2 Sep 2008 20:54:59 -0000 Received: (qmail 25519 invoked by uid 22791); 2 Sep 2008 20:54:58 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 02 Sep 2008 20:54:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 803AD2A9634; Tue, 2 Sep 2008 16:54:21 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id YVftBgOlGEMR; Tue, 2 Sep 2008 16:54:21 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 292A42A961B; Tue, 2 Sep 2008 16:54:21 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 11BB9E7ACD; Tue, 2 Sep 2008 22:54:17 +0200 (CEST) Date: Tue, 02 Sep 2008 20:54:00 -0000 From: Joel Brobecker To: Aleksandar Ristovski Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] step over permanent breakpoint Message-ID: <20080902205416.GA3774@adacore.com> References: <20080818110709.GD16894@adacore.com> <48AAE8D7.7040608@qnx.com> <20080825163516.GA31707@adacore.com> <48BD5D64.1050708@qnx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48BD5D64.1050708@qnx.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00020.txt.bz2 > >Also, I don't completely understand the ".1" part of your regexp. And > >the gdb_test_multiple documentation also says that you should include > >the final newline and prompt. So I suggest: > > > > -re ".*($hex).*$gdb_prompt $". > It was a shortcut for "\\\$1". > Changed. Haaaaaa, you meant to match the "$" part of the output, right? > 2008-09-02 Aleksandar Ristovski > > * breakpoint.c (breakpoint_init_inferior): Mark as not inserted only > non-permanent breakpoints. > (bpstat_stop_status): Change enable_state to bp_disabled only for > non-permanent breakpoints. > (bp_loc_is_permanent): New function. > (create_breakpoint): Check if the location points to a permanent > breakpoint and if it does, make breakpoint permanent. > (update_breakpoint_locations): Make sure new locations of permanent > breakpoints are properly initialized. > * i386-tdep.c (i386_skip_permanent_breakpoint): New function. > (i386_gdbarch_init): Set gdbarch_skip_permanent_breakpoint. This is OK, just remember to make a couple of tiny little adjustments: > + /* Update locationos of permanent breakpoints. */ ^^^^^^^^^^ spelling > @@ -8152,6 +8189,7 @@ single_step_breakpoint_inserted_here_p ( > return 0; > } > > + > > /* This help string is used for the break, hbreak, tbreak and thbreak commands. > It is defined as a macro to prevent duplication. This hunk (adding an extra new line before the ^L is unnecessary). > 2008-09-02 Aleksandar Ristovski > > * gdb.arch/i386-bp_permanent.exp: New test. This is also OK. -- Joel