Re: [rfc][00/37] Eliminate builtin_type_ macros

Mark Kettenis
2008-09-02T10:22:44Z

> Date: Mon, 1 Sep 2008 20:56:41 +0200 (CEST)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
>
> Mark Kettenis wrote:
>
> > I've probably had one piwo too many at this point, but can we please
> > stop this Linux [x/zillion] crap? You can't seriously pretend there
> > are really 37 independent diffs that people would want to review
> > and/or test can you?
>
> Actually, the patches *do* touch mostly independent areas of GDB,
> and I'd expect different maintainers to want to review only some
> of them. I've spent some effort to try to separate out functional
> changes, in the hope of making review simpler ...

Let me say that even if I think it doesn't really help, I apreciate
the effort.

> As to *testing*, I agree that having to apply 37 patches in sequence
> is a pain, which is why I sent -in addition to the broken-out series-
> a single cumulative patch as well.

Yes, that was a good thing to do. I apologize for sending the message
I sent yesterday evening before reading all my mail.

> In the end, this is simply a large set of changes (the cumulative patch
> is 8000 lines, the broken-out patches total 10000 lines) spread out
> across many parts of GDB (the patch set touches 97 files) -- if you have
> suggestions how to present a change like this in a way that's easier to
> review, those would certainly be welcome.

I don't think there is much you can do about it. A large set of
fairly mechanical changes is simply a large set of mechanical changes.
It's probably good if people have a look at part of the diff, but in
the end we'll just have to trust that the job was done properly and
that it gets committed (preferably after people have tested it).