From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6781 invoked by alias); 1 Sep 2008 16:51:49 -0000 Received: (qmail 6773 invoked by uid 22791); 1 Sep 2008 16:51:48 -0000 X-Spam-Check-By: sourceware.org Received: from host0.dyn.jankratochvil.net (HELO host0.dyn.jankratochvil.net) (89.250.240.59) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 01 Sep 2008 16:51:14 +0000 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.2) with ESMTP id m81Gp7BT008901; Mon, 1 Sep 2008 18:51:07 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id m81Gp74E008898; Mon, 1 Sep 2008 18:51:07 +0200 Date: Mon, 01 Sep 2008 16:51:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Daniel Jacobowitz Subject: Re: [patch] Fix crash on reading gcc HEAD Fortran module Message-ID: <20080901165107.GA7457@host0.dyn.jankratochvil.net> References: <20080901130212.GA8993@host0.dyn.jankratochvil.net> <20080901152956.GA15230@caradoc.them.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline In-Reply-To: <20080901152956.GA15230@caradoc.them.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00006.txt.bz2 --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 697 On Mon, 01 Sep 2008 17:29:56 +0200, Daniel Jacobowitz wrote: > please complain about children in DW_TAG_imported_declaration even in > Fortran (see the comment above your change). Originally I expected these complaints are just for detected DWARF violations: _("Offset %d out of bounds for DW_AT_ranges attribute"), But they are produced even just for unsupported DWARF features: complaint (&symfile_complaints, _("unsupported tag: '%s'"), Therefore it should always complain to any such DW_TAG_imported_* tag as they are always at least unsupported. (And it does not matter if some of their forms with or without children are invalid for DWARF or not.) [ approval requested ] Thanks, Jan --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="gdb-cvs-module-import.patch" Content-length: 994 2008-09-01 Jan Kratochvil Stay compatible after the GCC PR fortran/29635 fix. * dwarf2read.c (process_die ) (process_die ): Do not assert anything about these unsupported tags. --- ./gdb/dwarf2read.c 29 Aug 2008 17:06:05 -0000 1.278 +++ ./gdb/dwarf2read.c 1 Sep 2008 16:35:17 -0000 @@ -2760,10 +2760,10 @@ process_die (struct die_info *die, struc information contained in these. DW_TAG_imported_declaration dies shouldn't have children; DW_TAG_imported_module dies shouldn't in the C++ case, but conceivably could in the - Fortran case, so we'll have to replace this gdb_assert if - Fortran compilers start generating that info. */ + Fortran case. */ processing_has_namespace_info = 1; - gdb_assert (die->child == NULL); + complaint (&symfile_complaints, _("unsupported tag: '%s'"), + dwarf_tag_name (die->tag)); break; default: new_symbol (die, NULL, cu); --OXfL5xGRrasGEqWY--