From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9459 invoked by alias); 1 Sep 2008 15:30:41 -0000 Received: (qmail 9449 invoked by uid 22791); 1 Sep 2008 15:30:40 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 01 Sep 2008 15:30:01 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 8EA4498417; Mon, 1 Sep 2008 15:29:58 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 736A9983A9; Mon, 1 Sep 2008 15:29:58 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KaBLo-00042j-VS; Mon, 01 Sep 2008 11:29:57 -0400 Date: Mon, 01 Sep 2008 15:30:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix crash on reading gcc HEAD Fortran module Message-ID: <20080901152956.GA15230@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , gdb-patches@sourceware.org References: <20080901130212.GA8993@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080901130212.GA8993@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00004.txt.bz2 On Mon, Sep 01, 2008 at 03:02:12PM +0200, Jan Kratochvil wrote: > 2008-09-01 Jan Kratochvil > > Stay compatible after the GCC PR fortran/29635 fix. > * dwarf2read.c (process_die ): Accept (ignored) > child DIEs. Only COMPLAINT for non-Fortran languages. This patch is mostly OK; please complain about children in DW_TAG_imported_declaration even in Fortran (see the comment above your change). -- Daniel Jacobowitz CodeSourcery