From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] Fix crash on reading gcc HEAD Fortran module
Date: Mon, 01 Sep 2008 13:02:00 -0000 [thread overview]
Message-ID: <20080901130212.GA8993@host0.dyn.jankratochvil.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 407 bytes --]
Hi,
with the current gcc snapshot this testcase
MODULE m
integer :: varx
END MODULE m
USE m, a=>varx
end
crashes gdb HEAD on `break 2' with:
dwarf2read.c:2766: internal-error: process_die: Assertion `die->child == NULL' failed.
A problem internal to GDB has been detected,
While it still cannot reach the imported variables it at least no longer
crashes now. Notified by Tobias Burnus.
Regards,
Jan
[-- Attachment #2: gdb-cvs-module-import.patch --]
[-- Type: text/plain, Size: 864 bytes --]
2008-09-01 Jan Kratochvil <jan.kratochvil@redhat.com>
Stay compatible after the GCC PR fortran/29635 fix.
* dwarf2read.c (process_die <DW_TAG_imported_module>): Accept (ignored)
child DIEs. Only COMPLAINT for non-Fortran languages.
--- gdb/dwarf2read.c 29 Aug 2008 17:06:05 -0000 1.278
+++ gdb/dwarf2read.c 1 Sep 2008 12:56:19 -0000
@@ -2763,7 +2763,10 @@ process_die (struct die_info *die, struc
Fortran case, so we'll have to replace this gdb_assert if
Fortran compilers start generating that info. */
processing_has_namespace_info = 1;
- gdb_assert (die->child == NULL);
+ if (cu->language != language_fortran && die->child == NULL)
+ complaint (&symfile_complaints,
+ _("%s at offset %d has unexpected children"),
+ dwarf_tag_name (die->tag), die->offset);
break;
default:
new_symbol (die, NULL, cu);
next reply other threads:[~2008-09-01 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 13:02 Jan Kratochvil [this message]
2008-09-01 15:30 ` Daniel Jacobowitz
2008-09-01 16:51 ` Jan Kratochvil
2008-09-01 22:18 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080901130212.GA8993@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox