From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2439 invoked by alias); 31 Aug 2008 22:20:00 -0000 Received: (qmail 2426 invoked by uid 22791); 31 Aug 2008 22:19:59 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 31 Aug 2008 22:19:24 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id m7VMIHQG007851; Mon, 1 Sep 2008 00:18:17 +0200 (CEST) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id m7VMIGPq030239; Mon, 1 Sep 2008 00:18:16 +0200 (CEST) Date: Sun, 31 Aug 2008 22:20:00 -0000 Message-Id: <200808312218.m7VMIGPq030239@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: uweigand@de.ibm.com CC: gdb-patches@sourceware.org In-reply-to: <20080831175045.128504000@de.ibm.com> (uweigand@de.ibm.com) Subject: Re: [rfc][00/37] Eliminate builtin_type_ macros References: <20080831175045.128504000@de.ibm.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00711.txt.bz2 > Date: Sun, 31 Aug 2008 19:50:45 +0200 > From: uweigand@de.ibm.com > > Hello, > > one of the last remaining "implicit" uses of current_gdbarch is the > builtin_type_ macros. This patch set completely removes those macros. > > I've attempted to not simply replace those types with explict uses of > current_gdbarch, but instead choose the proper architecture to use: > > - I've added a gdbarch pointer to struct expression, and used this > per-expression arch throughout expression parsing and evaluation. > - I've converted some types (like builtin_void_type) back to be > platform-neutral, so they can be freely used throughout GDB. > - In many cases, an existing per-frame or per-objfile arch was available > (or could be made available) and should be used. > - Target-specific code should use target_gdbarch. > - In a very small number of case, current_gdbarch remains for now. > > Each of the following patches contains a more specific explanation. > > Combination of all 37 patches tested on amd64-linux, s390-ibm-linux, > s390x-ibm-linux, powerpc-linux, powerpc64-linux, and spu-elf with no > regressions. Also, compile-tested with --enable-targets=all (each > patch by itself). > > I'd be interested in particular in feedback from the Ada maintainers > on the Ada-related changes in this patch-set. > > What do you think? I've probably had one piwo too many at this point, but can we please stop this Linux [x/zillion] crap? You can't seriously pretend there are really 37 independent diffs that people would want to review and/or test can you?