From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23439 invoked by alias); 31 Aug 2008 17:52:22 -0000 Received: (qmail 23214 invoked by uid 22791); 31 Aug 2008 17:52:17 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 31 Aug 2008 17:51:33 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id m7VHpU6O279652 for ; Sun, 31 Aug 2008 17:51:30 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m7VHpTZa2822170 for ; Sun, 31 Aug 2008 19:51:29 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m7VHpQGX020097 for ; Sun, 31 Aug 2008 19:51:26 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m7VHpQKR020094 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 31 Aug 2008 19:51:26 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (localhost.localdomain [127.0.0.1]) by tuxmaker.boeblingen.de.ibm.com (8.13.8/8.13.8) with ESMTP id m7VHpPHe002620 for ; Sun, 31 Aug 2008 19:51:25 +0200 Received: (from uweigand@localhost) by tuxmaker.boeblingen.de.ibm.com (8.13.8/8.13.8/Submit) id m7VHpPDj002619 for gdb-patches@sourceware.org; Sun, 31 Aug 2008 19:51:25 +0200 Message-Id: <20080831175125.539279000@de.ibm.com> References: <20080831175045.128504000@de.ibm.com> User-Agent: quilt/0.46-1 Date: Sun, 31 Aug 2008 17:53:00 -0000 From: uweigand@de.ibm.com To: gdb-patches@sourceware.org Subject: [rfc][14/37] Eliminate builtin_type_ macros: Implicit dereferencing of references Content-Disposition: inline; filename=diff-type-deref Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00699.txt.bz2 Hello, when implicitly dereferencing a reference, the valprint routines manually construct a pointer type. This is superfluous, as the unpack_pointer routine already handles references fine. Bye, Ulrich ChangeLog: * ada-valprint.c (ada_val_print_1): When implicitly dereferencing a reference type, pass the reference type directly to unpack_pointer. * c-valprint.c (c_val_print): Likewise. * f-valprint.c (f_val_print): Likewise. * m2-valprint.c (print_variable_at_address, m2_val_print): Likewise. * p-valprint.c (pascal_val_print): Likewise. Index: gdb-head/gdb/ada-valprint.c =================================================================== --- gdb-head.orig/gdb/ada-valprint.c +++ gdb-head/gdb/ada-valprint.c @@ -891,9 +891,7 @@ ada_val_print_1 (struct type *type, cons if (TYPE_CODE (elttype) != TYPE_CODE_UNDEF) { - LONGEST deref_val_int = (LONGEST) - unpack_pointer (lookup_pointer_type (builtin_type_void), - valaddr); + LONGEST deref_val_int = (LONGEST) unpack_pointer (type, valaddr); if (deref_val_int != 0) { struct value *deref_val = Index: gdb-head/gdb/c-valprint.c =================================================================== --- gdb-head.orig/gdb/c-valprint.c +++ gdb-head/gdb/c-valprint.c @@ -310,8 +310,7 @@ c_val_print (struct type *type, const gd struct value *deref_val = value_at (TYPE_TARGET_TYPE (type), - unpack_pointer (lookup_pointer_type (builtin_type_void), - valaddr + embedded_offset)); + unpack_pointer (type, valaddr + embedded_offset)); common_val_print (deref_val, stream, format, deref_ref, recurse, pretty, current_language); } Index: gdb-head/gdb/f-valprint.c =================================================================== --- gdb-head.orig/gdb/f-valprint.c +++ gdb-head/gdb/f-valprint.c @@ -444,8 +444,7 @@ f_val_print (struct type *type, const gd struct value *deref_val = value_at (TYPE_TARGET_TYPE (type), - unpack_pointer (lookup_pointer_type (builtin_type_void), - valaddr + embedded_offset)); + unpack_pointer (type, valaddr + embedded_offset)); common_val_print (deref_val, stream, format, deref_ref, recurse, pretty, current_language); } Index: gdb-head/gdb/m2-valprint.c =================================================================== --- gdb-head.orig/gdb/m2-valprint.c +++ gdb-head/gdb/m2-valprint.c @@ -258,10 +258,7 @@ print_variable_at_address (struct type * if (TYPE_CODE (elttype) != TYPE_CODE_UNDEF) { struct value *deref_val = - value_at - (TYPE_TARGET_TYPE (type), - unpack_pointer (lookup_pointer_type (builtin_type_void), - valaddr)); + value_at (TYPE_TARGET_TYPE (type), unpack_pointer (type, valaddr)); common_val_print (deref_val, stream, format, deref_ref, recurse, pretty, current_language); } @@ -420,8 +417,7 @@ m2_val_print (struct type *type, const g struct value *deref_val = value_at (TYPE_TARGET_TYPE (type), - unpack_pointer (lookup_pointer_type (builtin_type_void), - valaddr + embedded_offset)); + unpack_pointer (type, valaddr + embedded_offset)); common_val_print (deref_val, stream, format, deref_ref, recurse, pretty, current_language); } Index: gdb-head/gdb/p-valprint.c =================================================================== --- gdb-head.orig/gdb/p-valprint.c +++ gdb-head/gdb/p-valprint.c @@ -267,8 +267,7 @@ pascal_val_print (struct type *type, con struct value *deref_val = value_at (TYPE_TARGET_TYPE (type), - unpack_pointer (lookup_pointer_type (builtin_type_void), - valaddr + embedded_offset)); + unpack_pointer (type, valaddr + embedded_offset)); common_val_print (deref_val, stream, format, deref_ref, recurse + 1, pretty, current_language); } -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com