Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: "Doug Evans" <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] fix thinko in pre/post hook help output
Date: Sat, 30 Aug 2008 15:05:00 -0000	[thread overview]
Message-ID: <200808301604.40222.pedro@codesourcery.com> (raw)
In-Reply-To: <e394668d0808291855n7784e410rbf65669f856713fc@mail.gmail.com>

On Saturday 30 August 2008 02:55:59, Doug Evans wrote:

> Oh bother.  I guess it can be interpreted that way.  Serves me right
> for assuming interpreting English is obvious.
> Reverted.

I'm very sorry, and it serves me right to learn to keep quiet.  :-(   Indeed,
it can be interpreted both ways.  It's the use of "This command"
possibly refering to a different command from the previous sentence
also using "This command", that makes it ambiguous, IMHO; but
the ':' may point out that it is refering to the following command.

How about we close this issue with changing the output to:

  This command has the following hook (or hooks) defined:
          The following command is run before: %s (pre hook)
          The following command is run after : %s (post hook)

?

-- 
Pedro Alves


      reply	other threads:[~2008-08-30 15:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29 23:56 Doug Evans
2008-08-30  0:18 ` Pedro Alves
2008-08-30  1:56   ` Doug Evans
2008-08-30 15:05     ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808301604.40222.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox