From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-58242-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14361 invoked by alias); 30 Aug 2008 00:18:47 -0000
Received: (qmail 14350 invoked by uid 22791); 30 Aug 2008 00:18:47 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 30 Aug 2008 00:18:12 +0000
Received: (qmail 26685 invoked from network); 30 Aug 2008 00:18:08 -0000
Received: from unknown (HELO orlando.local) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 30 Aug 2008 00:18:08 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] fix thinko in pre/post hook help output
Date: Sat, 30 Aug 2008 00:18:00 -0000
User-Agent: KMail/1.9.9
Cc: Doug Evans <dje@google.com>
References: <20080829235547.5279D1C7801@localhost>
In-Reply-To: <20080829235547.5279D1C7801@localhost>
MIME-Version: 1.0
Content-Type: text/plain;   charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200808300118.26587.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-08/txt/msg00665.txt.bz2

On Saturday 30 August 2008 00:55:47, Doug Evans wrote:
> fyi, checked in as obvious (swap before/after).
>
> 2008-08-29  Doug Evans  <dje@google.com>
>
> 	* cli/cli-decode.c (help_cmd): Fix thinko in pre/post hook help output.
>
> Index: cli/cli-decode.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/cli/cli-decode.c,v
> retrieving revision 1.69
> diff -u -p -u -p -r1.69 cli-decode.c
> --- cli/cli-decode.c	30 Jul 2008 01:10:17 -0000	1.69
> +++ cli/cli-decode.c	29 Aug 2008 23:48:28 -0000
> @@ -797,12 +797,12 @@ help_cmd (char *command, struct ui_file
>                        "\nThis command has a hook (or hooks) defined:\n");
>
>    if (c->hook_pre)
> -    fprintf_filtered (stream,
> -                      "\tThis command is run after  : %s (pre hook)\n",
> +    fprintf_filtered (stream,
> +                      "\tThis command is run before : %s (pre hook)\n",
>                      c->hook_pre->name);

I don't think this change is correct.  The command refered to in this
context does run *after* the pre-hook,

>    if (c->hook_post)
> -    fprintf_filtered (stream,
> -                      "\tThis command is run before : %s (post hook)\n",
> +    fprintf_filtered (stream,
> +                      "\tThis command is run after  : %s (post hook)\n",
>                      c->hook_post->name);
>  }

and *before* the post-hook runs.  E.g.,

  (gdb) define hook-thread
  Type commands for definition of "hook-thread".
  End with a line saying just "end".
  >print "before"
  >end
  (gdb) help thread
  ...
  This command has a hook (or hooks) defined:
          This command is run after  : hook-thread (pre hook)
  (gdb) thread
  $1 = "before"
  [Current thread is 1 (Thread 0x7ffff7fd46e0 (LWP 7467))]
  (gdb)

"thread" does runs *after* "hook-thread".

-- 
Pedro Alves