From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16990 invoked by alias); 29 Aug 2008 15:23:08 -0000 Received: (qmail 16980 invoked by uid 22791); 29 Aug 2008 15:23:08 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 29 Aug 2008 15:22:28 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 902FF9818A; Fri, 29 Aug 2008 14:24:22 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 3CB8C98189; Fri, 29 Aug 2008 14:24:20 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KZ4tf-000459-0b; Fri, 29 Aug 2008 10:24:19 -0400 Date: Fri, 29 Aug 2008 15:23:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Make attach_command exception-safe Message-ID: <20080829142418.GA15675@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200808291110.43091.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200808291110.43091.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00659.txt.bz2 On Fri, Aug 29, 2008 at 07:10:42AM +0000, Vladimir Prus wrote: > > When attach_command executes, it might disable stdin. It further might > throw, and does not enable stdin in that case. For CLI case, top-level > event loop will catch the exception and enable stdin. For MI case, MI > interpreter catches the exception in order to print the error message, > and of course it has no idea about any stdin disabling. > > This patch makes attach_command exception-safe, enabling stdin on > throw. > > OK? OK. > ChangeLog.csl | 6 ++++++ Not that bit :-) -- Daniel Jacobowitz CodeSourcery