From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32167 invoked by alias); 28 Aug 2008 15:56:05 -0000 Received: (qmail 32159 invoked by uid 22791); 28 Aug 2008 15:56:04 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 28 Aug 2008 15:55:23 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id F287E98189 for ; Thu, 28 Aug 2008 15:55:21 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id D4E1598187 for ; Thu, 28 Aug 2008 15:55:21 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KYjqC-00061F-Nj for gdb-patches@sourceware.org; Thu, 28 Aug 2008 11:55:20 -0400 Date: Thu, 28 Aug 2008 15:56:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: RFC: Do not call write_pc for "signal SIGINT" Message-ID: <20080828155520.GA23110@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00651.txt.bz2 This FIXME has been there since the dawn of CVS. Removing it causes no testsuite regressions on x86_64-linux; I don't think it will on other platforms either. Any comments on this patch? Otherwise I'll check it in after a little while. This isn't the only place where Linux's internal errno codes can leak back into user programs because of how we fiddle orig_eax. I'll file another bug report about that. -- Daniel Jacobowitz CodeSourcery 2008-08-28 Daniel Jacobowitz PR gdb/2241 * infcmd.c (signal_command): Do not specify a resume PC. Index: infcmd.c =================================================================== RCS file: /cvs/src/src/gdb/infcmd.c,v retrieving revision 1.200 diff -u -p -r1.200 infcmd.c --- infcmd.c 21 Aug 2008 20:13:08 -0000 1.200 +++ infcmd.c 28 Aug 2008 15:51:15 -0000 @@ -1123,11 +1123,7 @@ signal_command (char *signum_exp, int fr } clear_proceed_status (); - /* "signal 0" should not get stuck if we are stopped at a breakpoint. - FIXME: Neither should "signal foo" but when I tried passing - (CORE_ADDR)-1 unconditionally I got a testsuite failure which I haven't - tried to track down yet. */ - proceed (oursig == TARGET_SIGNAL_0 ? (CORE_ADDR) -1 : stop_pc, oursig, 0); + proceed ((CORE_ADDR) -1, oursig, 0); } /* Proceed until we reach a different source line with pc greater than