From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5924 invoked by alias); 25 Aug 2008 02:36:19 -0000 Received: (qmail 5916 invoked by uid 22791); 25 Aug 2008 02:36:18 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 25 Aug 2008 02:35:42 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id DAC9F981F0 for ; Mon, 25 Aug 2008 02:35:39 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id AF4D5981EF for ; Mon, 25 Aug 2008 02:35:39 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KXRve-0005DZ-Pr for gdb-patches@sourceware.org; Sun, 24 Aug 2008 22:35:38 -0400 Date: Mon, 25 Aug 2008 02:36:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: RFA: fix in features/Makefile Message-ID: <20080825023538.GA20039@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20080824223751.GB7324@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00608.txt.bz2 On Sun, Aug 24, 2008 at 06:02:40PM -0600, Tom Tromey wrote: > Yeah, I should have looked first. > > I disabled stdout buffering and used frysk's ftrace to get a stack > trace at the point where the weird stuff is written: > > #0 0x00110416 in __kernel_vsyscall() from [vdso] > #1 0x05e4d135 in new_do_write() from libc-2.7.so > #2 0x05e4d41f in _IO_do_write@@GLIBC_2.1() from libc-2.7.so > #3 0x05e4dd28 in _IO_file_overflow@@GLIBC_2.1() from libc-2.7.so > #4 0x05e50793 in __overflow() from libc-2.7.so > #5 0x05e4a55b in putc() from libc-2.7.so > #6 0x082f35c5 in _rl_output_character_function() from gdb > #7 0x006c554a in tputs() from libtinfo.so.5.6 > #8 0x082f3741 in _rl_enable_meta_key() from gdb > #9 0x082df0d8 in readline_initialize_everything() from gdb > #10 0x082def5c in rl_initialize() from gdb > #11 0x081a6081 in tui_initialize_readline() from gdb > #12 0x081a6ab7 in tui_init() from gdb stdout isn't a tty... dubious we should be doing this if it is. I'm not sure why you get tui here, though, I don't think I do. Do you have the gdbtui binary installed as gdb? > Tom> This patch also makes it so that the .c files are always rebuilt in > Tom> response to a 'make'. Without the FORCE code, make was not running > Tom> the rule for me. > > Daniel> If you're going to change the generating code, IMO it's reasonable to > Daniel> remove and remake the generated files by hand... > > Note that due to the use of move-if-change, you only get updates if > there really were any. This change just makes it simpler to ask for > the changes. I don't really care either way though. Makes sense, this makefile is already for manual use only and it's not like they take a long time. -- Daniel Jacobowitz CodeSourcery