From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26324 invoked by alias); 24 Aug 2008 22:38:36 -0000 Received: (qmail 26314 invoked by uid 22791); 24 Aug 2008 22:38:35 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 24 Aug 2008 22:37:54 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 43BA1981F0; Sun, 24 Aug 2008 22:37:52 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 254D3981EF; Sun, 24 Aug 2008 22:37:52 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KXODX-0001zR-Ib; Sun, 24 Aug 2008 18:37:51 -0400 Date: Sun, 24 Aug 2008 22:38:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFA: fix in features/Makefile Message-ID: <20080824223751.GB7324@caradoc.them.org> Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00605.txt.bz2 On Sun, Aug 24, 2008 at 12:11:03PM -0600, Tom Tromey wrote: > When regenerating some files in features using features/Makefile, I > saw some strange control characters show up at the start of the > generated files. > > This patch changes features/Makefile to use gdb's logging feature > rather than redirection to create the output files. This fixed the > problem I saw. But why did it? If you can't redirect GDB's output, something's wrong. > This patch also makes it so that the .c files are always rebuilt in > response to a 'make'. Without the FORCE code, make was not running > the rule for me. If you're going to change the generating code, IMO it's reasonable to remove and remake the generated files by hand... > Also, it would be nice if someone documented which .xml->.c > translations are to be checked in. I ran the rule with XMLTOC set to > all the .xml files under features, and I got a bunch of new files that > aren't in the repository. IMO the canonical list ought to be set in > features/Makefile somewhere. Sounds reasonable. It's all the ones with a full target description (rather than a single feature), I believe. -- Daniel Jacobowitz CodeSourcery