From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Don't output [Switching to ...] when connecting
Date: Fri, 22 Aug 2008 13:17:00 -0000 [thread overview]
Message-ID: <200808221417.57435.pedro@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
This patch reverts to setting previous_inferior_ptid where it
used to. I had moved this a while back, because I was using
previous_inferior_ptid differently in non-stop, but that is no longer
true, so we can just revert back.
The effect is that we revert to the old behaviour of not outputting
[Switching to Thread ...] message when connecting with target remote, or
any other "target xxx", which can be confusing if the target doesn't
support threads.
Tested on x86_64-unknown-linux-gnu sync and async, and confirmed that
the message is now gone when we connect to target remote.
OK?
--
Pedro Alves
[-- Attachment #2: no_message_start_remote.diff --]
[-- Type: text/x-diff, Size: 1781 bytes --]
2008-08-22 Pedro Alves <pedro@codesourcery.com>
* infrun.c (proceed): Move back setting previous_inferior_ptid
from here ...
(wait_for_inferior): ... to here.
(fetch_inferior_event): ... and here.
---
infrun.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
Index: gdb/infrun.c
===================================================================
--- gdb.orig/infrun.c 2008-08-22 13:22:08.000000000 +0100
+++ gdb/infrun.c 2008-08-22 13:53:00.000000000 +0100
@@ -1353,9 +1353,6 @@ proceed (CORE_ADDR addr, enum target_sig
/* Fill in with reasonable starting values. */
init_thread_stepping_state (tss);
- /* We'll update this if & when we switch to a new thread. */
- previous_inferior_ptid = inferior_ptid;
-
/* Reset to normal state. */
init_infwait_state ();
@@ -1536,6 +1533,9 @@ wait_for_inferior (int treat_exec_as_sig
overlay_cache_invalid = 1;
+ /* We'll update this if & when we switch to a new thread. */
+ previous_inferior_ptid = inferior_ptid;
+
/* We have to invalidate the registers BEFORE calling target_wait
because they can be loaded from the target while in target_wait.
This makes remote debugging a bit more efficient for those
@@ -1588,6 +1588,13 @@ fetch_inferior_event (void *client_data)
overlay_cache_invalid = 1;
+ /* We can only rely on wait_for_more being correct before handling
+ the event in all-stop, but previous_inferior_ptid isn't used in
+ non-stop. */
+ if (!ecs->wait_some_more)
+ /* We'll update this if & when we switch to a new thread. */
+ previous_inferior_ptid = inferior_ptid;
+
if (non_stop)
/* In non-stop mode, the user/frontend should not notice a thread
switch due to internal events. Make sure we reverse to the
next reply other threads:[~2008-08-22 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 13:17 Pedro Alves [this message]
2008-08-22 13:49 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808221417.57435.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox