From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: remote-mips.c, always a thread
Date: Mon, 18 Aug 2008 13:07:00 -0000 [thread overview]
Message-ID: <200808181407.35078.pedro@codesourcery.com> (raw)
In-Reply-To: <200808181329.28252.pedro@codesourcery.com>
On Monday 18 August 2008 13:29:28, Pedro Alves wrote:
> - mips_load was clearing inferior_ptid, and calling clear_symtab_users. I
> notice that inferior_ptid is being cleared after a load command, but that
> is wrong, I believe. See this change of Jim's to monitor.c, that removed
> this clearing from the monitor target:
> http://sourceware.org/ml/gdb/2001-09/msg00125.html
>
> I'm applying the exact same reasoning and change here.
>
Hmmm, I just noticed that mips_kill is being used to interrupting
the target ( '\03' / ^C / SIGINT ), instead of installing a SIGINT
handler like at least monitor.c, remote.c and remote-sim.c do.
This looks broken to me -- target_kill is definitelly not the
right target method for this (and neither is the "kill" command).
> This hasn't been tested at all, but, does it looks reasonable?
I forgot to add a new target_thread_alive function, otherwise,
info threads gets rid of the thread I just added.
--
Pedro Alves
next prev parent reply other threads:[~2008-08-18 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 12:29 Pedro Alves
2008-08-18 13:07 ` Pedro Alves [this message]
2008-08-19 19:38 ` [02/02] remote-mips.c, always a thread (take 2) Pedro Alves
2008-08-19 19:38 ` [01/02] " Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808181407.35078.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox