From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Introduce "target_gdbarch" variable
Date: Mon, 18 Aug 2008 11:34:00 -0000 [thread overview]
Message-ID: <20080818113323.GF16894@adacore.com> (raw)
In-Reply-To: <200808131952.m7DJqVoN009120@d12av02.megacenter.de.ibm.com>
Just my 2 cents...
> The idea is that this variable would stay even as other uses of
> current_gdbarch are being eliminated in favor of per-thread etc.
> architectures.
I am wondering why these ones are OK to stay, or perhaps you were
thinking of a short-to-medium term situation. Otherwise, isn't this
global going to be a problem with true multi-arch? Another situation
where this might be a problem is when the debugger is debugging more
than one process from different architectures (Stan's project).
> - Giving these uses a different name makes it more obvious that the
> remaining uses of current_gdbarch should be eliminated while these
> can stay.
That's a good reason. In fact, I started with something similar when
I first worked on the project of getting rid of the "current_language"
global (which I haven't forgotten about!)
> Does this seem reasonable?
It seems reasonable to me, modulo the part where I don't understand
why the current globals used in target-remote/solib are OK to stay.
--
Joel
next prev parent reply other threads:[~2008-08-18 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 19:53 Ulrich Weigand
2008-08-18 11:34 ` Joel Brobecker [this message]
2008-08-18 13:59 ` Ulrich Weigand
2008-08-18 14:11 ` Joel Brobecker
2008-08-26 17:33 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818113323.GF16894@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox