From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16101 invoked by alias); 15 Aug 2008 14:16:58 -0000 Received: (qmail 16091 invoked by uid 22791); 15 Aug 2008 14:16:57 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 15 Aug 2008 14:16:22 +0000 Received: (qmail 32443 invoked from network); 15 Aug 2008 14:15:57 -0000 Received: from unknown (HELO localhost) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Aug 2008 14:15:57 -0000 From: Vladimir Prus To: Pedro Alves Subject: Re: [RFA] Remove unnecessary target defaults. Date: Fri, 15 Aug 2008 14:16:00 -0000 User-Agent: KMail/1.9.9 Cc: gdb-patches@sourceware.org References: <200808151645.31042.vladimir@codesourcery.com> <200808151408.42896.pedro@codesourcery.com> In-Reply-To: <200808151408.42896.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808151815.59911.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00406.txt.bz2 On Friday 15 August 2008 17:08:42 Pedro Alves wrote: > On Friday 15 August 2008 13:45:30, Vladimir Prus wrote: > > > - de_fault (to_can_async_p, > > - (int (*) (void)) > > - return_zero); > > - de_fault (to_is_async_p, > > - (int (*) (void)) > > - return_zero); > > I believe this is incorrect. You don't notice it when connected > to remote, because those methods are implemented in remote_ops. But, > when connected to e.g., remote-sim.c, and because gdbsim_ops doesn't define > those, you'll inherit the dummy target's implementation, which looks > for asyncness in the default run target instead --- while you should be > looking for asyncness in the remote-sim target. As we seem to have agreed on IRC, this is pre-existing problem. We inherit a method before applying defaults, so we'll always inherit dummy's version of to_is_async_p, and the code I remove above will never manage to change method to return_zero. The problem you raise is real, however. I think one approach to solve it is to just make remote-sim define to_can_async_p. More generic solution would be to arrange so that if we have a target on process stratum, it never goes to targets below for to_can_async_p. For example, if we have - exec - dummy and you do run, then target_can_async_p will look at exec, then at dummy, then find_default_can_async_p will return some results. But if we have - remote-sim - exec - dummy then target_can_async_p will either invoke a method in remote-sim (if present), or return 0. How does this sound? - Volodya