Re: [RFA] Remove unnecessary target defaults.

Daniel Jacobowitz
2008-08-16T20:15:55Z

On Fri, Aug 15, 2008 at 04:45:30PM +0400, Vladimir Prus wrote:
>
> In current GDB, at the bottom of the target stack, we always have dummy
> target, which defines some target methods, including to_create_inferiour,
> and to_attach. Those are implemented by calling find_default_attach
> and find_default_create_inferior, which will call 'error' when nothing
> is found.
>
> On the other hand, update_current_target tries to set a default value
> for those functions -- but because dummy target is always there, such
> defaulting is not necessary. This patch removes it. No regressions on x86.
>
> OK?
>
> - Volodya
>
> * target.c (maybe_kill_then_attach)
> (maybe_kill_then_create_inferior): Remove.
> (update_current_target): Do not default to_attach,
> to_create_inferiour, to_is_async_p.

Based on the discussion, this is OK.

--
Daniel Jacobowitz
CodeSourcery