From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11060 invoked by alias); 12 Aug 2008 20:37:45 -0000 Received: (qmail 11046 invoked by uid 22791); 12 Aug 2008 20:37:44 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Aug 2008 20:37:09 +0000 Received: (qmail 12301 invoked from network); 12 Aug 2008 20:37:07 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 12 Aug 2008 20:37:07 -0000 From: Pedro Alves To: Daniel Jacobowitz Subject: Re: Add a third mode to "breakpoints always-inserted", and make it the default Date: Tue, 12 Aug 2008 20:37:00 -0000 User-Agent: KMail/1.9.9 Cc: gdb-patches@sourceware.org, Eli Zaretskii References: <200808120034.25338.pedro@codesourcery.com> <200808122107.20295.pedro@codesourcery.com> <20080812201133.GA25501@caradoc.them.org> In-Reply-To: <20080812201133.GA25501@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808122137.00425.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00329.txt.bz2 On Tuesday 12 August 2008 21:11:33, Daniel Jacobowitz wrote: > On Tue, Aug 12, 2008 at 09:07:19PM +0100, Pedro Alves wrote: > > > Also, it would be helpful to have an index entry here, something like > > > > > > @cindex non-stop mode, and @code{breakpoint always-inserted} > > > > Done, and done, I think. > > No, you added: > > +@cindex non-stop mode > > I'm sure that one doesn't go here :-) > Where does it go then? I generated html, and I see two "non-stop mode" index entries, one of them points here, to the auto option, the other points to the "set non-stop mode" option. > > + if (always_inserted_mode == always_inserted_auto) > > + fprintf_filtered (file, > > + _("Always inserted breakpoint mode is %s (currently %s).\n"), > > + value, non_stop ? "on" : "off"); > > I suggest calling breakpoints_always_inserted_mode here instead of > checking non_stop. Sure. > > Otherwise, the code looks fine - though I'd like to reach an agreement > with Vladimir about set non-stop first. Certainly. -- Pedro Alves