From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22316 invoked by alias); 11 Aug 2008 19:40:02 -0000 Received: (qmail 22254 invoked by uid 22791); 11 Aug 2008 19:39:58 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 11 Aug 2008 19:39:19 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id BB43B983B4; Mon, 11 Aug 2008 19:39:17 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id A44B898215; Mon, 11 Aug 2008 19:39:17 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KSdEb-0001hN-35; Mon, 11 Aug 2008 15:39:17 -0400 Date: Mon, 11 Aug 2008 19:40:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [remote protocol] support for disabling packet acknowledgement Message-ID: <20080811193917.GA6176@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <200807101823.13728.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200807101823.13728.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00302.txt.bz2 On Thu, Jul 10, 2008 at 06:23:13PM +0100, Pedro Alves wrote: > Hi, > > This patch adds support to the remote protocol to disable packet > acknowlegment. This is useful when the transport being used is itself > reliable, e.g., TCP/IP. In these cases, by removing the acking > we reduce the amount of roundtrips, and decrease the communication > latency. > > While we were discussing implementing this, I noticed that Apple > already had something of the sort, so we ended up reusing Apple's > QStartNoAckMode packet name, and basing our implementation on > their version, modernizing it, adding qSupport support > to it, tweaking the user interface so it is integrated with > the "set remote xxx-packet" set of commands, and documenting it. > > The docs changes below explain more in detail the approach taken. > > I'm including in the patch GDB changes to support the feature, > and adding the support to gdbserver. Regtesting against a native > gdbserver on x86_64-unknown-linux-gnu doesn't show any regression. This patch is OK, with the two texinfo corrections from Eli, and without this: > Index: src/gdb/gdbserver/remote-utils.c > =================================================================== > --- src.orig/gdb/gdbserver/remote-utils.c 2008-07-10 17:37:11.000000000 +0100 > +++ src/gdb/gdbserver/remote-utils.c 2008-07-10 17:38:08.000000000 +0100 > @@ -90,7 +90,7 @@ static struct sym_cache *symbol_cache; > failures. */ > int all_symbols_looked_up; > > -int remote_debug = 0; > +int remote_debug = 1; > struct ui_file *gdb_stdlog; > > static int remote_desc = INVALID_DESCRIPTOR; Also, could you please add a NEWS entry (there's a new packet and new associated commands). -- Daniel Jacobowitz CodeSourcery