From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28433 invoked by alias); 10 Aug 2008 17:41:00 -0000 Received: (qmail 28421 invoked by uid 22791); 10 Aug 2008 17:40:59 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 10 Aug 2008 17:40:24 +0000 Received: (qmail 11432 invoked from network); 10 Aug 2008 17:40:22 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Aug 2008 17:40:22 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: Patches to build on DJGPP Date: Sun, 10 Aug 2008 17:41:00 -0000 User-Agent: KMail/1.9.9 Cc: Mark Kettenis References: <200808092241.46195.pedro@codesourcery.com> <200808101536.m7AFadSV028043@brahms.sibelius.xs4all.nl> In-Reply-To: <200808101536.m7AFadSV028043@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808101840.25872.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00279.txt.bz2 On Sunday 10 August 2008 16:36:39, Mark Kettenis wrote: > > > > Index: src/gdb/buildsym.c > > =================================================================== > > --- src.orig/gdb/buildsym.c 2008-08-09 20:55:28.000000000 +0100 > > +++ src/gdb/buildsym.c 2008-08-09 22:27:04.000000000 +0100 > > @@ -547,7 +547,7 @@ start_subfile (char *name, char *dirname > > && !IS_ABSOLUTE_PATH (subfile->name) > > && subfile->dirname != NULL) > > subfile_name = concat (subfile->dirname, SLASH_STRING, > > - subfile->name, NULL); > > + subfile->name, (void*) NULL); > > else > > subfile_name = subfile->name; > > There's a space missing; should be (void *) instead of (void*). > However, I think one can argue that one should use (char *) here. > Same for xml-tdep.c further down. Thanks, I will change it. I see you've indeed fixed similar cases before for OpenBSD/gcc4. > > > Index: src/gdb/posix-hdep.c > > =================================================================== > > --- src.orig/gdb/posix-hdep.c 2008-08-09 20:55:39.000000000 +0100 > > +++ src/gdb/posix-hdep.c 2008-08-09 22:27:04.000000000 +0100 > > @@ -24,6 +24,12 @@ > > > > #include "gdb_select.h" > > > > +#ifdef __GO32__ > > +/* DJGPP defines the fd_set type in sys/types.h, but `select' goes > > + here. */ > > +# include > > +#endif > > + > > /* The strerror() function can return NULL for errno values that are > > out of range. Provide a "safe" version that always returns a > > printable string. */ > > Like I wrote in another reply, I think we should include > in gdb_select.h, instead of adding this #ifdef __GO32__ here. I just checked that this in gdb_select.h, and dropping the include in posix-hdep.c buils fine in DJGPP. --- src.orig/gdb/gdb_select.h +++ src/gdb/gdb_select.h @@ -22,10 +22,8 @@ #ifdef HAVE_SYS_SELECT_H #include -#endif - -#ifdef HAVE_SYS_TYPES_H -#include +#else +#include #endif We already include sys/time.h in common code without a HAVE_SYS... wrapper (event-loop.c), so I guess this is the best to do here? -- Pedro Alves