Re: ttrace: Protocal error

Joel Brobecker
2008-08-09T14:53:18Z

> 2008-08-08 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
>
> * inf-ttrace.c (inf_ttrace_resume_callback): Don't resume dying thread.

That looks OK, but did you check the effect on the testsuite results?
I want to make sure that we're not causing a program to hang at the end
just because a dying thread wasn't allowed to die.

Also, I wonder why we're deleting the "dying" threads from the thread list
at resume time:

static void
inf_ttrace_resume (ptid_t ptid, int step, enum target_signal signal)
{
[...]
if (ptid_equal (ptid, minus_one_ptid) && inf_ttrace_num_lwps > 0)
{
/* Let all the other threads run too. */
iterate_over_threads (inf_ttrace_resume_callback, NULL);
iterate_over_threads (inf_ttrace_delete_dying_threads_callback, NULL);
}
}

--
Joel