From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30769 invoked by alias); 9 Aug 2008 14:31:33 -0000 Received: (qmail 30758 invoked by uid 22791); 9 Aug 2008 14:31:30 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 09 Aug 2008 14:30:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C86C12A9744; Sat, 9 Aug 2008 10:30:53 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3ilYe0jcg55L; Sat, 9 Aug 2008 10:30:53 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 534942A970B; Sat, 9 Aug 2008 10:30:53 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id EB3DEE7ACD; Sat, 9 Aug 2008 16:30:45 +0200 (CEST) Date: Sat, 09 Aug 2008 14:31:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Use is_stopped, instead of !is_running Message-ID: <20080809143045.GC4936@adacore.com> References: <200807291459.12056.pedro@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200807291459.12056.pedro@codesourcery.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00237.txt.bz2 > 2008-07-29 Pedro Alves > > * gdbthread.h: Add comments. > * stack.c (get_selected_block): Return 0 on an exited thread. > * top.c (execute_command): Check for is_stopped, not !is_running. > * event-top.c (command_handler): Likewise. Looks OK to me. It took me a while to decide that it was OK to leave one instance inside inf-loop.c, but I think the !is_running there is OK. -- Joel