Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pedro@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: [2/7] Add the attached-to thread in inf_ptrace_attach
Date: Fri, 08 Aug 2008 21:50:00 -0000	[thread overview]
Message-ID: <200808082148.m78LmEcf020275@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <200808080235.13509.pedro@codesourcery.com> (message from Pedro 	Alves on Fri, 8 Aug 2008 02:35:13 +0100)

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Fri, 8 Aug 2008 02:35:13 +0100
> 
> This patch makes sure that the thread/task we attach to with ptrace
> targets is added to GDB's thread table.  Targets that extend
> inf-ptrace (inf_ptrace_target) should then use thread_change_ptid
> as soon as then have more lwp or tid info, instead of just setting
> inferior_ptid.  Targets that don't have a process_stratum target
> overriding inf_ptrace_attach get it for free (BSD targets).
> 
> This was tested together with the rest of the series on
> x86_64-unknown-linux-gnu, i386-unknown-openbsd4.3, i386-unknown-freebsd6.0
> and i386-unknown-freebsd7.0.
> 
> OK?

Had the inf-ptrace.c bit in my tree too.  So that's defenitely ok.

I always get headaches when I look at linux-nat.c, so I'll trust you
on that one.

> 2008-08-08  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* inf-ptrace.c: Include "gdbthread.h".
> 	(inf_ptrace_attach): Add the main thread here.
> 	* linux-nat.c (linux_nat_attach): Don't add the main thread here.
> 	Decorate the main thread id with the lwp id.


      reply	other threads:[~2008-08-08 21:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08  1:35 Pedro Alves
2008-08-08 21:50 ` Mark Kettenis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808082148.m78LmEcf020275@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox