From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31680 invoked by alias); 8 Aug 2008 17:16:41 -0000 Received: (qmail 31669 invoked by uid 22791); 8 Aug 2008 17:16:41 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 08 Aug 2008 17:16:06 +0000 Received: from wpaz17.hot.corp.google.com (wpaz17.hot.corp.google.com [172.24.198.81]) by smtp-out.google.com with ESMTP id m78HFxJZ028398 for ; Fri, 8 Aug 2008 18:16:00 +0100 Received: from localhost (elbrus.corp.google.com [172.18.116.17]) by wpaz17.hot.corp.google.com with ESMTP id m78HFth6014058; Fri, 8 Aug 2008 10:15:56 -0700 Received: by localhost (Postfix, from userid 74925) id 5293C3A67D1; Fri, 8 Aug 2008 10:15:55 -0700 (PDT) To: gdb-patches@sourceware.org Cc: ppluzhnikov@google.com Subject: [patch] Fix for gdb.base/args.exp when ~/.gdbinit has "set confirm off" Message-Id: <20080808171555.5293C3A67D1@localhost> Date: Fri, 08 Aug 2008 17:16:00 -0000 From: ppluzhnikov@google.com (Paul Pluzhnikov) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00210.txt.bz2 Greetings, gdb.base/args.exp has been failing for me (and it takes a looong time to fail), because I have "set confirm off" in ~/.gdbinit. Attached patch fixes that. Committed as obvious. -- Paul Pluzhnikov 2008-08-08 Paul Pluzhnikov * gdb.base/args.exp: Prevent ~/.gdbinit from affecting test. Index: gdb.base/args.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/args.exp,v retrieving revision 1.14 diff -u -p -u -r1.14 args.exp --- gdb.base/args.exp 6 Aug 2008 12:52:06 -0000 1.14 +++ gdb.base/args.exp 8 Aug 2008 17:07:42 -0000 @@ -71,7 +71,7 @@ proc args_test { name arglist } { # Test that the --args are processed correctly. # set old_gdbflags $GDBFLAGS -set GDBFLAGS "--args $binfile 1 3" +set GDBFLAGS "-nx --args $binfile 1 3" args_test basic {{1} {3}} # @@ -79,21 +79,21 @@ args_test basic {{1} {3}} # The syntax needed is a little peculiar; DejaGNU treats the arguments as a # list and expands them itself, since no shell redirection is involved. # -set GDBFLAGS "--args $binfile 1 {} 3" +set GDBFLAGS "-nx --args $binfile 1 {} 3" args_test "one empty" {{1} {} {3}} # # try with 2 empty args # -set GDBFLAGS "--args $binfile 1 {} {} 3" +set GDBFLAGS "-nx --args $binfile 1 {} {} 3" args_test "two empty" {{1} {} {} 3} # Try with arguments containing literal single quotes. -set GDBFLAGS "--args $binfile 1 '' 3" +set GDBFLAGS "-nx --args $binfile 1 '' 3" args_test "one empty (with single quotes)" {{1} {''} {3}} -set GDBFLAGS "--args $binfile 1 '' '' 3" +set GDBFLAGS "-nx --args $binfile 1 '' '' 3" args_test "two empty (with single quotes)" {{1} {''} {''} {3}} set GDBFLAGS $old_gdbflags