From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27347 invoked by alias); 7 Aug 2008 20:46:21 -0000 Received: (qmail 27337 invoked by uid 22791); 7 Aug 2008 20:46:20 -0000 X-Spam-Check-By: sourceware.org Received: from merkur.ins.uni-bonn.de (HELO merkur.ins.uni-bonn.de) (131.220.223.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 07 Aug 2008 20:45:28 +0000 Received: from localhost.localdomain (xdsl-87-78-69-216.netcologne.de [87.78.69.216]) by merkur.ins.uni-bonn.de (Postfix) with ESMTP id 21B5D40000485; Thu, 7 Aug 2008 22:45:26 +0200 (CEST) Received: from ralf by localhost.localdomain with local (Exim 4.63) (envelope-from ) id 1KRCLx-0004tu-9Z; Thu, 07 Aug 2008 22:44:57 +0200 Date: Thu, 07 Aug 2008 20:46:00 -0000 From: Ralf Wildenhues To: Tom Tromey Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: automatic dependency tracking Message-ID: <20080807204456.GA18762@ins.uni-bonn.de> References: <20080807054840.GA26651@ins.uni-bonn.de> <20080807191516.GG27560@ins.uni-bonn.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00159.txt.bz2 * Tom Tromey wrote on Thu, Aug 07, 2008 at 10:06:16PM CEST: > >>>>> "Ralf" == Ralf Wildenhues writes: > > >> FWIW I did not want to change where the build puts objects; I didn't > >> see a particular benefit to doing this. > > Ralf> It allows you to remove about 190 lines from the Makefile. > Ralf> If you like, I can redo the patch or post a followup one, for this. > > I am curious about this. I thought old-style '.c.o' rules did not > handle subdirectories properly. Is that not so? Or, what approach > were you planning to take? Yes, I was going to rely on '.c.o' rules. I don't remember problems with subdirectories in .c.o rules, other than maybeee on Solaris 2.6. But I tend to forget the details (and GNU make works on that system), on I cannot find anything else problematic. Maybe you are thinking of compiler problems with "-c -o"? Anyway, automake.in has had this encouraging note since 2003 (handle_single_transform, indentation dropped): [...] # If both source and object files are in a subdirectory # (this happens when the subdir-objects option is used), # then the inference will work. # # The latter case deserves a historical note. When the # subdir-objects option was added on 1999-04-11 it was # thought that inferences rules would work for # subdirectory objects too. Later, on 1999-11-22, # automake was changed to output explicit rules even for # subdir-objects. Nobody remembers why, but this occurred # soon after the merge of the user-dep-gen-branch so it # might be related. In late 2003 people complained about # the size of the generated Makefile.ins (libgcj, with # 2200+ subdir objects was reported to have a 9MB # Makefile), so we now rely on inference rules again. # Maybe we'll run across the same issue as in the past, # but at least this time we can document it. However since # dependency tracking has evolved it is possible that # our old problem no longer exists. # Using inference rules for subdir-objects has been tested # with GNU make, Solaris make, Ultrix make, BSD make, # HP-UX make, and OSF1 make successfully. > I think you should put your name on the ChangeLog entry. Fine with me. Do you want me to re-post the patch for this? ;-) Cheers, Ralf