From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26751 invoked by alias); 6 Aug 2008 11:26:30 -0000 Received: (qmail 26742 invoked by uid 22791); 6 Aug 2008 11:26:30 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 06 Aug 2008 11:25:50 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 8F3FE98420; Wed, 6 Aug 2008 11:25:48 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 74E9B98337; Wed, 6 Aug 2008 11:25:48 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KQh9H-0007og-US; Wed, 06 Aug 2008 07:25:47 -0400 Date: Wed, 06 Aug 2008 11:26:00 -0000 From: Daniel Jacobowitz To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFA] remove unnecessary alloca/memcpy in write_memory Message-ID: <20080806112547.GA30014@caradoc.them.org> Mail-Followup-To: Doug Evans , gdb-patches@sourceware.org References: <20080806044718.E1D301C77BE@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080806044718.E1D301C77BE@localhost> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00107.txt.bz2 On Tue, Aug 05, 2008 at 09:47:18PM -0700, Doug Evans wrote: > Hi. Any ideas why the call to alloca/memcpy? > [Why not pass myaddr to target_write_memory directly?] No good reason, patch is OK. -- Daniel Jacobowitz CodeSourcery