From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25423 invoked by alias); 6 Aug 2008 11:25:14 -0000 Received: (qmail 25415 invoked by uid 22791); 6 Aug 2008 11:25:13 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 06 Aug 2008 11:24:34 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 08944983EF; Wed, 6 Aug 2008 11:24:33 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id C2F1E98337; Wed, 6 Aug 2008 11:24:32 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KQh84-0007o3-60; Wed, 06 Aug 2008 07:24:32 -0400 Date: Wed, 06 Aug 2008 11:25:00 -0000 From: Daniel Jacobowitz To: Vinay Sridhar Cc: Jan Kratochvil , gdb-patches@sources.redhat.com, luisgpm@linux.vnet.ibm.com, uweigand@de.ibm.com Subject: Re: [patch] Re: Accessing tls variables across files causes a bug Message-ID: <20080806112432.GA29991@caradoc.them.org> Mail-Followup-To: Vinay Sridhar , Jan Kratochvil , gdb-patches@sources.redhat.com, luisgpm@linux.vnet.ibm.com, uweigand@de.ibm.com References: <1217480020.4755.1.camel@vinaysridhar.in.ibm.com> <20080802171807.GA2755@host0.dyn.jankratochvil.net> <1217925527.3658.41.camel@vinaysridhar.in.ibm.com> <20080805122118.GB17219@caradoc.them.org> <1218021410.13466.4.camel@vinaysridhar.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1218021410.13466.4.camel@vinaysridhar.in.ibm.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00106.txt.bz2 On Wed, Aug 06, 2008 at 04:46:50PM +0530, Vinay Sridhar wrote: > We need to determine that the variable is a "tls" variable. When this is > extern, the symbol is LOC_UNRESOLVED. So the section type from "sym" is > not filled. Thats why I tried to determine this from the minimal symbol. > If there is any other method of determining a variable is "tls" before > its owning symtab is linked in, could you please inform? I used this > section number as I could not find another way of determining this.. I imagine that Jan's right and we need to treat all unresolved symbols this way - or be less eager about creating unresolved symbols. -- Daniel Jacobowitz CodeSourcery