From: dje@google.com (Doug Evans)
To: drow@google.com
Cc: gdb-patches@sourceware.org
Subject: [RFC] confusing comment in memory_xfer_partial
Date: Wed, 06 Aug 2008 05:25:00 -0000 [thread overview]
Message-ID: <20080806052434.5137E1C77BE@localhost> (raw)
Hi. I don't understand this comment in memory_xfer_partial.
The code has already checked for writing to read-only memory
and reading from write-only memory. And in this `else' clause
we know readbuf is NULL.
Can you elaborate on what the comment is about?
Preserve who's const correctness?
2008-08-05 Doug Evans <dje@google.com>
* target.c (memory_xfer_partial): Delete outdated comment.
Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.169
diff -u -p -u -p -r1.169 target.c
--- target.c 9 Jul 2008 22:42:42 -0000 1.169
+++ target.c 6 Aug 2008 05:15:03 -0000
@@ -1071,9 +1071,6 @@ memory_xfer_partial (struct target_ops *
res = dcache_xfer_memory (target_dcache, memaddr, readbuf,
reg_len, 0);
else
- /* FIXME drow/2006-08-09: If we're going to preserve const
- correctness dcache_xfer_memory should take readbuf and
- writebuf. */
res = dcache_xfer_memory (target_dcache, memaddr,
(void *) writebuf,
reg_len, 1);
next reply other threads:[~2008-08-06 5:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 5:25 Doug Evans [this message]
2008-08-06 5:29 ` Doug Evans
2008-08-06 5:41 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080806052434.5137E1C77BE@localhost \
--to=dje@google.com \
--cc=drow@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox