From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18428 invoked by alias); 5 Aug 2008 13:26:31 -0000 Received: (qmail 18225 invoked by uid 22791); 5 Aug 2008 13:26:27 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 05 Aug 2008 13:25:30 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m75DPRPo008568 for ; Tue, 5 Aug 2008 09:25:27 -0400 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m75DPOAm026473 for ; Tue, 5 Aug 2008 09:25:26 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.stuttgart.redhat.com (8.13.1/8.13.1) with ESMTP id m75DPMAD012825 for ; Tue, 5 Aug 2008 09:25:23 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.2) with ESMTP id m75DPLp3002944; Tue, 5 Aug 2008 15:25:21 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id m75DPKxY002941; Tue, 5 Aug 2008 15:25:20 +0200 Date: Tue, 05 Aug 2008 13:26:00 -0000 From: Jan Kratochvil To: Luis Machado Cc: gdb-patches@sources.redhat.com Subject: [patch] Finish removing (PR gdb/1543) Message-ID: <20080805132520.GA1645@host0.dyn.jankratochvil.net> References: <1217480020.4755.1.camel@vinaysridhar.in.ibm.com> <20080802171807.GA2755@host0.dyn.jankratochvil.net> <1217877435.29334.98.camel@gargoyle> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="PNTmBPCT7hxwcZjr" Content-Disposition: inline In-Reply-To: <1217877435.29334.98.camel@gargoyle> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00076.txt.bz2 --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1305 On Mon, 04 Aug 2008 21:17:14 +0200, Luis Machado wrote: > On Sat, 2008-08-02 at 19:18 +0200, Jan Kratochvil wrote: ... > > + Please email any bugs, comments, and/or additions to this file to: > > + bug-gdb@prep.ai.mit.edu */ > > This header is probably very old. Newer testcases have a more up-to-date > header. For example, gdb.opt/clobbered-registers-O2.c. I already faced this problem before, I was not aware of the differences. This time I did a copy from file with recent enough modification timestamp. Patch finally closes PR gdb/1543, its full contens is 115KB so I left it at: http://people.redhat.com/jkratoch/gdb-testsuite-mail-remove.patch I found no other files (besides fixed `sep.exp') referencing absolute numbers in the changed .c files. Also no other testcases had regressions on x86_64. $ grep '\(bigcore\|break\|break1\|callfuncs\|cvexpr\|del\|nofield\|pending\|pendshr\|randomize\|sep-proc\|sep\|sepdebug\|sigaltstack\|start\|step-bt\|structs\|value-double-free\|mi-pending\|mi-pendshr\)[.]c:[0-9]' */*.exp gdb.base/sep.exp:gdb_test "list sep-proc.c:23" \ gdb.base/sep.exp:gdb_test_multiple "break sep-proc.c:25" "$test" { (Testcases `gdb.base/bigcore.exp' and `gdb.base/condbreak.exp' changed the reported PASS messages content containing the line number.) Regards, Jan --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="gdb-testsuite-mail-remove-reduced.patch" Content-length: 7165 2008-08-05 Jan Kratochvil Fix for PR gdb/1543. * gdb.base/sep.exp: `sep-proc.c' absolute line numbers replaced with $LOCATION. (location): New variable. * config/cfdbug.exp, config/d10v.exp, config/dve.exp, config/i960.exp, config/m32r.exp, config/mn10300-eval.exp, config/proelf.exp, config/rom68k.exp, config/sh.exp, config/unix.exp, config/vr4300.exp, config/vr5000.exp, config/vxworks.exp, gdb.arch/altivec-regs.exp, gdb.arch/e500-abi.exp, gdb.arch/e500-regs.exp, gdb.asm/asm-source.exp, gdb.base/a2-run.exp, gdb.base/advance.exp, gdb.base/all-bin.exp, gdb.base/args.exp, gdb.base/arithmet.exp, gdb.base/assign.exp, gdb.base/async.exp, gdb.base/auxv.exp, gdb.base/bigcore.c, gdb.base/bigcore.exp, gdb.base/bitfields.exp, gdb.base/bitops.exp, gdb.base/break.c, gdb.base/break.exp, gdb.base/break1.c, gdb.base/call-ar-st.exp, gdb.base/call-rt-st.exp, gdb.base/call-strs.exp, gdb.base/callfuncs.c, gdb.base/callfuncs.exp, gdb.base/checkpoint.exp, gdb.base/chng-syms.exp, gdb.base/code-expr.exp, gdb.base/commands.exp, gdb.base/completion.exp, gdb.base/complex.exp, gdb.base/cond-expr.exp, gdb.base/condbreak.exp, gdb.base/consecutive.exp, gdb.base/corefile.exp, gdb.base/cvexpr.c, gdb.base/cvexpr.exp, gdb.base/dbx.exp, gdb.base/default.exp, gdb.base/define.exp, gdb.base/del.c, gdb.base/detach.exp, gdb.base/display.exp, gdb.base/dump.exp, gdb.base/echo.exp, gdb.base/environ.exp, gdb.base/eval-skip.exp, gdb.base/exprs.exp, gdb.base/fileio.exp, gdb.base/find.exp, gdb.base/finish.exp, gdb.base/funcargs.exp, gdb.base/gcore-buffer-overflow.exp, gdb.base/gcore.exp, gdb.base/gdb1555.exp, gdb.base/gdbvars.exp, gdb.base/help.exp, gdb.base/huge.exp, gdb.base/info-proc.exp, gdb.base/interrupt.exp, gdb.base/jump.exp, gdb.base/langs.exp, gdb.base/lineinc.exp, gdb.base/list.exp, gdb.base/macscp.exp, gdb.base/maint.exp, gdb.base/mips_pro.exp, gdb.base/miscexprs.exp, gdb.base/nodebug.exp, gdb.base/nofield.c, gdb.base/opaque.exp, gdb.base/overlays.exp, gdb.base/page.exp, gdb.base/pc-fp.exp, gdb.base/pending.c, gdb.base/pendshr.c, gdb.base/pointers.exp, gdb.base/psymtab.exp, gdb.base/ptype.exp, gdb.base/randomize.c, gdb.base/readline.exp, gdb.base/recurse.exp, gdb.base/regs.exp, gdb.base/relational.exp, gdb.base/relocate.exp, gdb.base/remote.exp, gdb.base/reread.exp, gdb.base/return.exp, gdb.base/return2.exp, gdb.base/scope.exp, gdb.base/sect-cmd.exp, gdb.base/sep-proc.c, gdb.base/sep.c, gdb.base/sep.exp, gdb.base/sepdebug.c, gdb.base/sepdebug.exp, gdb.base/setshow.exp, gdb.base/shlib-call.exp, gdb.base/sigaltstack.c, gdb.base/so-indr-cl.exp, gdb.base/solib.exp, gdb.base/source.exp, gdb.base/start.c, gdb.base/step-bt.c, gdb.base/step-line.exp, gdb.base/structs.c, gdb.base/structs.exp, gdb.base/structs2.exp, gdb.base/term.exp, gdb.base/twice.exp, gdb.base/type-opaque.exp, gdb.base/until.exp, gdb.base/value-double-free.c, gdb.base/varargs.exp, gdb.base/watchpoint.exp, gdb.base/whatis-exp.exp, gdb.disasm/am33.exp, gdb.disasm/h8300s.exp, gdb.disasm/hppa.exp, gdb.disasm/mn10300.exp, gdb.disasm/sh3.exp, gdb.disasm/t01_mov.exp, gdb.disasm/t02_mova.exp, gdb.disasm/t03_add.exp, gdb.disasm/t04_sub.exp, gdb.disasm/t05_cmp.exp, gdb.disasm/t06_ari2.exp, gdb.disasm/t07_ari3.exp, gdb.disasm/t08_or.exp, gdb.disasm/t09_xor.exp, gdb.disasm/t10_and.exp, gdb.disasm/t11_logs.exp, gdb.disasm/t12_bit.exp, gdb.disasm/t13_otr.exp, gdb.fortran/exprs.exp, gdb.fortran/types.exp, gdb.hp/gdb.aCC/exception.exp, gdb.hp/gdb.aCC/optimize.exp, gdb.hp/gdb.aCC/watch-cmd.exp, gdb.hp/gdb.base-hp/callfwmall.exp, gdb.hp/gdb.base-hp/dollar.exp, gdb.hp/gdb.base-hp/hwwatchbus.exp, gdb.hp/gdb.base-hp/pxdb.exp, gdb.hp/gdb.base-hp/reg-pa64.exp, gdb.hp/gdb.base-hp/reg.exp, gdb.hp/gdb.base-hp/sized-enum.exp, gdb.hp/gdb.base-hp/so-thresh.exp, gdb.hp/gdb.compat/xdb1.exp, gdb.hp/gdb.compat/xdb2.exp, gdb.hp/gdb.compat/xdb3.exp, gdb.java/jmisc.exp, gdb.java/jv-exp.exp, gdb.java/jv-print.exp, gdb.mi/gdb669.exp, gdb.mi/gdb680.exp, gdb.mi/gdb701.exp, gdb.mi/gdb792.exp, gdb.mi/mi-basics.exp, gdb.mi/mi-console.exp, gdb.mi/mi-hack-cli.exp, gdb.mi/mi-pending.c, gdb.mi/mi-pendshr.c, gdb.mi/mi-pthreads.exp, gdb.mi/mi-read-memory.exp, gdb.mi/mi-regs.exp, gdb.mi/mi-syn-frame.exp, gdb.mi/mi-until.exp, gdb.mi/mi2-basics.exp, gdb.mi/mi2-console.exp, gdb.mi/mi2-hack-cli.exp, gdb.mi/mi2-pthreads.exp, gdb.mi/mi2-read-memory.exp, gdb.mi/mi2-regs.exp, gdb.mi/mi2-syn-frame.exp, gdb.mi/mi2-until.exp, gdb.pascal/types.exp, gdb.stabs/weird.exp, gdb.threads/gcore-thread.exp, gdb.threads/manythreads.exp, gdb.threads/print-threads.exp, gdb.threads/pthreads.exp, gdb.threads/schedlock.exp, gdb.threads/step.exp, gdb.threads/step2.exp, gdb.threads/switch-threads.exp, gdb.threads/thread-specific.exp, gdb.threads/thread_check.exp, gdb.threads/thread_events.exp, gdb.threads/tls-nodebug.exp, gdb.threads/tls-shared.exp, gdb.threads/tls.exp, gdb.trace/actions.exp, gdb.trace/backtrace.exp, gdb.trace/circ.exp, gdb.trace/collection.exp, gdb.trace/deltrace.exp, gdb.trace/infotrace.exp, gdb.trace/limits.exp, gdb.trace/packetlen.exp, gdb.trace/passc-dyn.exp, gdb.trace/passcount.exp, gdb.trace/report.exp, gdb.trace/save-trace.exp, gdb.trace/tfind.exp, gdb.trace/tracecmd.exp, gdb.trace/while-dyn.exp, gdb.trace/while-stepping.exp, lib/mi-support.exp, lib/trace-support.exp: Remove reference to bug-gdb@prep.ai.mit.edu . --- gdb/testsuite/gdb.base/sep.exp 1 Jan 2008 22:53:19 -0000 1.8 +++ gdb/testsuite/gdb.base/sep.exp 5 Aug 2008 13:05:17 -0000 @@ -12,9 +12,6 @@ # # You should have received a copy of the GNU General Public License # along with this program. If not, see . -# -# Please email any bugs, comments, and/or additions to this file to: -# bug-gdb@prep.ai.mit.edu if $tracelevel then { strace $tracelevel @@ -29,6 +26,8 @@ if { [gdb_compile "${srcdir}/${subdir}/ return -1 } +set location [gdb_get_line_number "say_hello" "sep-proc.c"] + gdb_exit gdb_start gdb_reinitialize_dir $srcdir/$subdir @@ -44,7 +43,7 @@ gdb_load ${binfile} # say_hello is good enough, and avoid unnecessary failures is someone # decides later to reformat sep-proc.c. -gdb_test "list sep-proc.c:23" \ +gdb_test "list sep-proc.c:$location" \ "void.*say_hello.*" \ "list using location inside included file" @@ -57,7 +56,7 @@ gdb_reinitialize_dir $srcdir/$subdir gdb_load ${binfile} set test "breakpoint inside included file" -gdb_test_multiple "break sep-proc.c:25" "$test" { +gdb_test_multiple "break sep-proc.c:$location" "$test" { -re "Breakpoint.*at.* file .*sep-proc.c, line .*" { pass "$test" } --- gdb/testsuite/config/cfdbug.exp 1 Jan 2008 22:53:15 -0000 1.5 +++ gdb/testsuite/config/cfdbug.exp 5 Aug 2008 13:04:56 -0000 @@ -13,7 +13,4 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . -# Please email any bugs, comments, and/or additions to this file to: -# bug-gdb@prep.ai.mit.edu - load_lib "../config/monitor.exp" etc. http://people.redhat.com/jkratoch/gdb-testsuite-mail-remove.patch --PNTmBPCT7hxwcZjr--