From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7159 invoked by alias); 31 Jul 2008 18:51:15 -0000 Received: (qmail 7150 invoked by uid 22791); 31 Jul 2008 18:51:14 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 31 Jul 2008 18:50:48 +0000 Received: (qmail 23893 invoked from network); 31 Jul 2008 18:50:46 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 31 Jul 2008 18:50:46 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, Tom Tromey Subject: Re: RFA: automatic dependency tracking Date: Thu, 31 Jul 2008 18:51:00 -0000 User-Agent: KMail/1.9.9 References: <200807301852.45352.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807311950.46853.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00586.txt.bz2 On Wednesday 30 July 2008 20:05:01, Tom Tromey wrote: > Pedro> I trust Tom. :-) > > Thanks. Though... we all make mistakes :) I trust you to be around to fix them. > One way you could help move this forward would be to test it on a > machine that does not have GNU make. I don't have one of these. As you know, I tested building GDB with BSD make. I used an x86 FreeBSD 6.0-RELEASE. src/opcodes needs a little tweak to build, http://sourceware.org/ml/binutils/2008-07/msg00403.html but other than that, pristine GDB builds fine with BSD make. > The patch probably doesn't apply cleanly any more. Unfortunately this > sort of patch requires constant care to keep it up-to-date. I tested with a checkout of the date of your patch to avoid that issue. GDB built perfectly with your patch, with BSD make with and without -j4 and with gmake also {,-j4}, always from a clean build dir. I used: >gcc -v Using built-in specs. Configured with: FreeBSD/i386 system compiler Thread model: posix gcc version 3.4.4 [FreeBSD] 20050518 In addition to doing a couple of touch,make tests, to check if dependencies are being respected with gmake, I tested building gdb in a clean build dir, waiting a couple of minutes, and then touching defs.h, and issuing gmake again. By checking timestamps, I found that these are the files weren't rebuilt by touching defs.h: 18:19 .. 18:22 .gdbinit 18:22 Makefile 18:22 ada-exp.c 18:22 ada-lex.c 18:22 c-exp.c 18:22 config.cache 18:22 config.h 18:22 config.log 18:22 config.status 18:22 cp-name-parser.c 18:22 doc 18:22 f-exp.c 18:22 gnulib 18:22 jv-exp.c 18:22 m2-exp.c 18:22 nm.h 18:22 objc-exp.c 18:22 observer.h 18:22 observer.inc 18:22 p-exp.c 18:22 stamp-h 18:22 stamp-h1 18:22 stamp-xml 18:22 testsuite 18:22 version.c 18:22 xml-builtin.c 18:23 cp-name-parser.o 18:23 version.o 18:24 xml-builtin.o With BSD make, touching header files doesn't trigger recompiles, as expected. -- Pedro Alves