From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30052 invoked by alias); 29 Jul 2008 16:32:48 -0000 Received: (qmail 30043 invoked by uid 22791); 29 Jul 2008 16:32:47 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Jul 2008 16:32:12 +0000 Received: (qmail 25775 invoked from network); 29 Jul 2008 16:32:10 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 29 Jul 2008 16:32:10 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: Use is_stopped, instead of !is_running Date: Tue, 29 Jul 2008 16:32:00 -0000 User-Agent: KMail/1.9.9 Cc: Thiago Jung Bauermann References: <200807291459.12056.pedro@codesourcery.com> <1217347148.5842.7.camel@localhost.localdomain> In-Reply-To: <1217347148.5842.7.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807291732.08263.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00543.txt.bz2 On Tuesday 29 July 2008 16:59:08, Thiago Jung Bauermann wrote: > If the thread state is not a boolean, then IMHO offering convenient > functions which treat it as such and then putting a warning in the > comment is really setting up a subtle trap for GDB hackers... :-) > > What about just nuking is_running and is_stopping, and making everybody > use is_thread_state directly? That would make this reality explicit. It might not look like it, but I'm doing baby steps in that direction. :-) There are target_has_execution checks inside the is_XXX functions that I'd like to cleanly get rid of. -- Pedro Alves