From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9292 invoked by alias); 26 Jul 2008 18:30:39 -0000 Received: (qmail 9284 invoked by uid 22791); 26 Jul 2008 18:30:39 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 26 Jul 2008 18:30:19 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id F400F98382; Sat, 26 Jul 2008 18:30:02 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id C01AD98376; Sat, 26 Jul 2008 18:29:57 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KMoWj-0003HA-50; Sat, 26 Jul 2008 14:29:57 -0400 Date: Sat, 26 Jul 2008 18:30:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: tromey@redhat.com, bauerman@br.ibm.com, gdb-patches@sourceware.org Subject: Re: [RFA][patch 1/9] Yet another respin of the patch with initial Python support Message-ID: <20080726182957.GA12363@caradoc.them.org> Mail-Followup-To: Eli Zaretskii , tromey@redhat.com, bauerman@br.ibm.com, gdb-patches@sourceware.org References: <20080615181833.uxmo25mg0kko40kw@imap.linux.ibm.com> <1216107418.14956.27.camel@localhost.localdomain> <1216245620.12209.18.camel@localhost.localdomain> <20080718195010.GA14356@caradoc.them.org> <1216653969.31797.6.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00492.txt.bz2 On Sat, Jul 26, 2008 at 09:10:18PM +0300, Eli Zaretskii wrote: > > >> +@value{GDBN} introduces a new Python module, named @code{gdb}. All > > >> +methods and classes added by @value{GDBN} are placed in this module. > > > > Eli> OK, but what does this mean for whoever writes Python extensions for > > Eli> GDB? While at that, how about explaining why a command FOO is indexed > > Eli> as gdb.FOO? > > > > I thought it would be nice to index them both ways. Do you disagree? > > > > Python programmers know what the module stuff means. We don't have to > > explain that. > > Sorry, I disagree. What would you like explained? I'm a bit confused - as a Python programmer, albeit novice, what Tom wrote makes sense to me. > > >> +Find the value of a @value{GDBN} setting. > > > > Eli> "find" or "display"? If the former, why the name is "show"? > > > > It mimics the CLI command name. > > ??? CLI commands that begin with "show" actually display the values. > This one does not, right? I suggest "get" parallel to "set", then. > > >> +Print a string to @value{GDBN}'s paginated standard output stream. > > >> +Ordinarily your program should not call this function directly; simply > > >> +print to @code{sys.stdout} as usual. > > > > Eli> So why is this command available, and why document it? > > > > Completeness. It is visible in the module. > > Doesn't sound like a good enough reason to me. Maybe we should move it to a new module gdb._internal then. Tom, what do you think? -- Daniel Jacobowitz CodeSourcery