Re: [FYI] Inlining support, rough patch

Daniel Jacobowitz
2009-06-27T18:01:34Z

On Mon, Apr 20, 2009 at 05:54:05PM +0200, Jan Kratochvil wrote:
> On Mon, 20 Apr 2009 17:49:09 +0200, Daniel Jacobowitz wrote:
> > Nothing algorithmic has changed,
> > but we have a few bug fixes and improved testcases.
>
> Fedora also has various fixes on top of it:
> http://cvs.fedora.redhat.com/viewvc/rpms/gdb/devel/gdb-6.8-inlining-addon.patch?view=co

Thanks for the link. Some of these I've already got fixes for.
For instance, the changes in breakpoint.c about returning from a
function to an inlined frame; I fixed it somewhere else, but we
did discover that problem.

Others, particularly the testsuite changes, I don't understand. I'd
need to see a compiler that failed to work out why the changes were
needed. So if you still need patches after the latest version of the
patch is checked in, please let me know and I'll reproduce the
failures.

current_pc_is_notcurrent is interesting. Do I have the scenario
right?

* function() calls inlined() calls other()
* finish from other()
* show the end of inlined() instead of the next line of function()

I can't figure out if we should do this or not. It does seem useful.
But that's not where we are; we're showing the previous call site
instead of the next instruction.

I think we should consider it as a general change for finish instead
of specific to inlining. The comments in your patch suggested that
too.

I merged the read_type_die fix, thanks.

--
Daniel Jacobowitz
CodeSourcery