From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20015 invoked by alias); 17 Jul 2008 18:36:03 -0000 Received: (qmail 20006 invoked by uid 22791); 17 Jul 2008 18:36:02 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Jul 2008 18:35:45 +0000 Received: from zps36.corp.google.com (zps36.corp.google.com [172.25.146.36]) by smtp-out.google.com with ESMTP id m6HIZef8006546 for ; Thu, 17 Jul 2008 19:35:41 +0100 Received: from localhost (elbrus.corp.google.com [172.18.116.17]) by zps36.corp.google.com with ESMTP id m6HIZZBI000406; Thu, 17 Jul 2008 11:35:36 -0700 Received: by localhost (Postfix, from userid 74925) id CF6C33A67B6; Thu, 17 Jul 2008 11:35:35 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [RFA] Fix for failing gdb.base/corefile.exp on Linux Message-Id: <20080717183535.CF6C33A67B6@localhost> Date: Thu, 17 Jul 2008 18:36:00 -0000 From: ppluzhnikov@google.com (Paul Pluzhnikov) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00341.txt.bz2 Greetings, (Some?) Linux kernels do not write out unmodified mmaped regions, which causes gdb.base/corefile.exp to fail: Running ../../../src/gdb/testsuite/gdb.base/corefile.exp ... FAIL: gdb.base/corefile.exp: accessing mmapped data in core file (mapping address not found in core file) Attached patch fixes that. Ok to commit? -- Paul Pluzhnikov 2008-07-17 Paul Pluzhnikov * gdb.base/coremaker.c: Fix for Linux failure in gdb.base/corefile.exp Index: testsuite/gdb.base/coremaker.c =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/coremaker.c,v retrieving revision 1.5 diff -u -p -u -r1.5 coremaker.c --- testsuite/gdb.base/coremaker.c 1 Jan 2008 22:53:18 -0000 1.5 +++ testsuite/gdb.base/coremaker.c 17 Jul 2008 18:29:50 -0000 @@ -96,6 +96,8 @@ mmapdata () return; } } + /* Touch buf2 so kernel writes it out into 'core'. */ + buf2[0] = buf1[0]; } void