From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27379 invoked by alias); 15 Jul 2008 19:22:36 -0000 Received: (qmail 27369 invoked by uid 22791); 15 Jul 2008 19:22:35 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 Jul 2008 19:22:15 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D9ADD98421; Tue, 15 Jul 2008 19:22:13 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id C3AFF98420; Tue, 15 Jul 2008 19:22:13 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KIq6H-0002ZU-55; Tue, 15 Jul 2008 15:22:13 -0400 Date: Tue, 15 Jul 2008 19:22:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [commit] Rename frame_pc_unwind and frame_unwind_id Message-ID: <20080715192213.GC3094@caradoc.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <20080715190125.GC32644@caradoc.them.org> <200807151908.m6FJ8YK3001326@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200807151908.m6FJ8YK3001326@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00325.txt.bz2 On Tue, Jul 15, 2008 at 09:08:34PM +0200, Mark Kettenis wrote: > > Date: Tue, 15 Jul 2008 15:01:25 -0400 > > From: Daniel Jacobowitz > > > > This patch is the first non-trivial change in inlining support, and > > readily separable. > > Non-trivial... > > > The users of frame_unwind_id and frame_pc_unwind are all either > > inferior control, trying to find the caller / return address of a new > > function, or trampoline handling. I audited all of the uses, and the > > right behavior in every one of them is to ignore any inlined functions > > at the current location. A future patch, the one adding inlined > > frames, will make the corresponding change to frame_unwind_caller_id > > and frame_unwind_caller_pc. For now, I've just renamed them to > > indicate the correct expectations. > > ...so cann't we discuss this first please? Sorry. Want me to back it out? I'm not going to commit anything further; I've just posted the meat of the patch, which is harder to separate. I'm interested in your comments (about this patch or the larger one). -- Daniel Jacobowitz CodeSourcery