From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14636 invoked by alias); 14 Jul 2008 17:27:17 -0000 Received: (qmail 14623 invoked by uid 22791); 14 Jul 2008 17:27:17 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 Jul 2008 17:26:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3A8F32A9737; Mon, 14 Jul 2008 13:26:51 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 95StDdIRfuCE; Mon, 14 Jul 2008 13:26:51 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 006EF2A96AD; Mon, 14 Jul 2008 13:26:50 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1322BE7ACD; Mon, 14 Jul 2008 10:26:49 -0700 (PDT) Date: Mon, 14 Jul 2008 17:27:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: Patch: annotations -vs- deprecated hooks Message-ID: <20080714172649.GD3998@adacore.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00284.txt.bz2 Nick: Would you like to do some testing before this patch gets checked in? (note that this is dependent on Tom's previous "observers" patch). Hi Tom, > There are still a couple of hooks called by the annotations code that > are used by gdbtk. This setup seems weird to me. I guess these ought > to be replaced by observers. I agree - I didn't check why gdbtk is dependent on annotation hooks, but we should also ask them about it, and try to remove these hooks. > b/gdb/ChangeLog: > 2008-07-13 Tom Tromey > > * annotate.h (deprecated_annotate_starting_hook): Remove. > (deprecated_annotate_stopped_hook): Remove. > (deprecated_annotate_exited_hook): Remove. > * Makefile.in (annotate.o): Depend on observer_h. > * top.c (deprecated_delete_breakpoint_hook): Remove. > (deprecated_create_breakpoint_hook): Likewise. > (deprecated_modify_breakpoint_hook): Likewise. > * interps.c (clear_interpreter_hooks): Update for removed hooks. > * breakpoint.c (mention): Don't call removed hook. > (delete_breakpoint): Likewise. > (disable_breakpoint): Likewise. > (do_enable_breakpoint): Likewise. > * annotate.c: Include observer.h. > (breakpoint_changed): Change type of argument. > (_initialize_annotate): Register observers. > (deprecated_annotate_starting_hook): Remove. > (deprecated_annotate_stopped_hook): Remove. > (deprecated_annotate_exited_hook): Remove. > (annotate_starting): Update for hook removal. > (annotate_stopped): Likewise. > (annotate_exited): Likewise. > * defs.h (deprecated_delete_breakpoint_hook): Remove. > (deprecated_create_breakpoint_hook): Likewise. > (deprecated_modify_breakpoint_hook): Likewise. This looks good to me. We have to wait a little bit for Vladimir's comments before you can commit the observers patch, so that should give Nick a little bit of time to do any testing he might need (although ideally running the testsuite should be enough). -- Joel