A Saturday 12 July 2008 19:54:48, Daniel Jacobowitz wrote:
> On Fri, Jul 11, 2008 at 09:38:55PM +0100, Pedro Alves wrote:
> > +  struct cleanup **as_cleanup_p = (struct cleanup **) &cmd_continuation;
> > +  make_cleanup_ftype *continuation_hook_ftype = continuation_hook;
>
> ftype stands for function type, and our convention is to use it for
> types only.  So please don't use it in the name of a variable.
> continuation_fn?

Ok.  I've fixed both instances.

> > +static void
> > +finish_command_continuation_free_arg (void *arg)
> > +{
> > +  /* NOTE: See finish_command_continuation.  This would go away, if
> > +     this suppressing is made a thread property.  */
> > +  suppress_stop_observer = 0;
> > +}
>
> Doesn't it still need to call xfree?
>

Indeed.

> Otherwise OK.

For the archives, attached is what I checked in after another
round of testing.

-- 
Pedro Alves