Re: [gdbserver] Fix attaching notices

[Pedro Alves <pedro@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

A Friday 11 July 2008 15:13:26, Daniel Jacobowitz wrote:
> On Tue, Jul 08, 2008 at 02:58:33AM +0100, Pedro Alves wrote:

> > 2) change the test to:
> >
> >       if (stop_soon == STOP_QUIETLY_NO_SIGSTOP
> > 	  && stop_signal == TARGET_SIGNAL_STOP
> > 	  && stop_signal == TARGET_SIGNAL_TRAP)
>
> Ought to be some || in there :-)
>

No kidding!  No more posting at 3AM for me.  :-)

> > 	{
> > 	  stop_stepping (ecs);
> > 	  stop_signal = TARGET_SIGNAL_0;
> > 	  return;
> > 	}
> >
> >    Or even add a `&& stop_signal == TARGET_SIGNAL_0', and merge
> >    this stop_soon with STOP_QUIETLY_REMOTE.
>
> I don't think I understand.
>

I think this is the same insanity as above :-)

> Allowing both stop and trap sounds reasonable to me.  We already rely
> on there not being other sources of SIGTRAP.

Here a patch for that.  I confirmed that the SIGTRAP notice is gone against
gdbserver, and ran the the attaching into signals tests, and the
attach.exp test nativelly, and all pass cleanly.

-- 
Pedro Alves

[-- Attachment #2: stop_soon_no_sigstop.diff --]
[-- Type: text/x-diff, Size: 1691 bytes --]

2008-07-11  Pedro Alves  <pedro@codesourcery.com>

	* infrun.c (handle_inferior_event): Also ignore a
	TARGET_SIGNAL_TRAP on a STOP_QUIETLY_NO_SIGSTOP.

---
 gdb/infrun.c |   17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

Index: src/gdb/infrun.c
===================================================================
--- src.orig/gdb/infrun.c	2008-07-11 16:33:00.000000000 +0100
+++ src/gdb/infrun.c	2008-07-11 16:41:51.000000000 +0100
@@ -2543,13 +2543,20 @@ targets should add new threads to the th
 	}
 
       /* This originates from attach_command().  We need to overwrite
-         the stop_signal here, because some kernels don't ignore a
-         SIGSTOP in a subsequent ptrace(PTRACE_CONT,SIGSTOP) call.
-         See more comments in inferior.h.  On the other hand, if we
+	 the stop_signal here, because some kernels don't ignore a
+	 SIGSTOP in a subsequent ptrace(PTRACE_CONT,SIGSTOP) call.
+	 See more comments in inferior.h.  On the other hand, if we
 	 get a non-SIGSTOP, report it to the user - assume the backend
-	 will handle the SIGSTOP if it should show up later.  */
+	 will handle the SIGSTOP if it should show up later.
+
+	 Also consider that the attach is complete when we see a
+	 SIGTRAP.  Some systems (e.g. Windows), and stubs supporting
+	 target extended-remote report it instead of a SIGSTOP
+	 (e.g. gdbserver).  We already rely on SIGTRAP being our
+	 signal, so this is no exception.  */
       if (stop_soon == STOP_QUIETLY_NO_SIGSTOP
-	  && stop_signal == TARGET_SIGNAL_STOP)
+	  && (stop_signal == TARGET_SIGNAL_STOP
+	      || stop_signal == TARGET_SIGNAL_TRAP))
 	{
 	  stop_stepping (ecs);
 	  stop_signal = TARGET_SIGNAL_0;