From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3264 invoked by alias); 11 Jul 2008 14:13:51 -0000 Received: (qmail 3228 invoked by uid 22791); 11 Jul 2008 14:13:48 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 Jul 2008 14:13:28 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D869798415; Fri, 11 Jul 2008 14:13:26 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id BA90E98376; Fri, 11 Jul 2008 14:13:26 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KHJNG-0001Xs-2l; Fri, 11 Jul 2008 10:13:26 -0400 Date: Fri, 11 Jul 2008 14:13:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [gdbserver] Fix attaching notices Message-ID: <20080711141326.GA5455@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <200806280011.12868.pedro@codesourcery.com> <20080707175510.GB1778@caradoc.them.org> <200807080051.46088.pedro@codesourcery.com> <200807080258.34187.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200807080258.34187.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00207.txt.bz2 On Tue, Jul 08, 2008 at 02:58:33AM +0100, Pedro Alves wrote: > > * infrun.c (handle_inferior_event): Do not ignore non-SIGSTOP while > > attaching. Use signal_stop_state. > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Bah. > So, we either > > 1) go with my patch (on which the win32 part was a hack, but I > can live with it), and live with the bogus notice > against older gdbservers, or > > 2) change the test to: > > if (stop_soon == STOP_QUIETLY_NO_SIGSTOP > && stop_signal == TARGET_SIGNAL_STOP > && stop_signal == TARGET_SIGNAL_TRAP) Ought to be some || in there :-) > { > stop_stepping (ecs); > stop_signal = TARGET_SIGNAL_0; > return; > } > > Or even add a `&& stop_signal == TARGET_SIGNAL_0', and merge > this stop_soon with STOP_QUIETLY_REMOTE. I don't think I understand. Allowing both stop and trap sounds reasonable to me. We already rely on there not being other sources of SIGTRAP. -- Daniel Jacobowitz CodeSourcery