From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: [MI non-stop 10/11] Skip varobj in running threads.
Date: Fri, 11 Jul 2008 14:02:00 -0000 [thread overview]
Message-ID: <20080711140143.GH2651@caradoc.them.org> (raw)
In-Reply-To: <200807111456.40088.pedro@codesourcery.com>
On Fri, Jul 11, 2008 at 02:56:39PM +0100, Pedro Alves wrote:
> You should reverse the logic, and do the update if the thread is_stopped
> instead of !is_running. That is because there is now exited state
> to care for as well, and is_running also returns false on those. Essentially,
> the is_STATE functions should not be tested with negation, if you're looking
> for a particular state.
Sounds like we need a big comment for that :-)
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-07-11 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-28 17:22 Vladimir Prus
2008-07-11 13:53 ` Daniel Jacobowitz
2008-07-11 19:07 ` Vladimir Prus
2008-07-11 13:57 ` Pedro Alves
2008-07-11 14:02 ` Daniel Jacobowitz [this message]
2008-07-13 5:34 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711140143.GH2651@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox