From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7520 invoked by alias); 11 Jul 2008 13:53:59 -0000 Received: (qmail 7512 invoked by uid 22791); 11 Jul 2008 13:53:59 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 Jul 2008 13:53:38 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 6DCBC98415; Fri, 11 Jul 2008 13:53:36 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 5880898376; Fri, 11 Jul 2008 13:53:36 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KHJ43-0001EG-Ir; Fri, 11 Jul 2008 09:53:35 -0400 Date: Fri, 11 Jul 2008 13:53:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [MI non-stop 10/11] Skip varobj in running threads. Message-ID: <20080711135335.GF2651@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200806282100.06214.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200806282100.06214.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00202.txt.bz2 On Sat, Jun 28, 2008 at 09:00:06PM +0400, Vladimir Prus wrote: > > If a variable object is bound to a specific thread, and we're doing > > -var-update * > > and varobj's thread is running, we cannot update varobj -- so we skip it. > Will commit when core non-stop is in. I think this needs to go in the manual. Would it be helpful to indicate to the front end that a variable could not be updated due to a running thread? If a varobj is bound to a particular thread that usually means it's bound to a particular frame, right? In which case reading it while the target is running doesn't make (much) sense, so there's nothing target specific about this. > + if (thread_id == 0 && is_executing (inferior_ptid)) > + thread_running = 1; > + else if (thread_id > 0) > + { > + struct thread_info *tp = find_thread_id (thread_id); > + if (tp) > + thread_running = is_running (tp->ptid); > + } Why is_running in one place and is_executing in the other? Should we try reading from something besides inferior_ptid for unbound varobjs? -- Daniel Jacobowitz CodeSourcery