From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20813 invoked by alias); 11 Jul 2008 12:50:31 -0000 Received: (qmail 20804 invoked by uid 22791); 11 Jul 2008 12:50:31 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 Jul 2008 12:49:53 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id CF35898415 for ; Fri, 11 Jul 2008 12:49:51 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 9FCCF98376 for ; Fri, 11 Jul 2008 12:49:51 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KHI4M-0000JL-H7 for gdb-patches@sourceware.org; Fri, 11 Jul 2008 08:49:50 -0400 Date: Fri, 11 Jul 2008 12:50:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [MI non-stop 04/11] Implement --thread and --frame. Message-ID: <20080711124950.GC31978@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <200806282044.14246.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200806282044.14246.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00189.txt.bz2 On Sat, Jun 28, 2008 at 08:44:14PM +0400, Vladimir Prus wrote: > > This implements the --thread and --frame options to all MI command. > Please see http://article.gmane.org/gmane.comp.gdb.devel/23414/ for > background design for --thread. The --frame is ideologically same > as --thread. > > The only non-MI change here is making find_thread_pid exported from > thread.c, which change seems obvious, so no approval is needed. Comments, > however, are much appreciated. There were a lot of comments on this patch, so I'll only skim it... might want to post an updated version. > + if (strncmp (chp, "--thread", 8) == 0) > + { > + if (parse->thread != -1) > + error ("Duplicate '--thread' option"); > + chp += 8; > + parse->thread = strtol (chp, &chp, 10); > + } Someone may have mentioned this, but I think you should check for "--thread " and "--frame " with trailing space. -- Daniel Jacobowitz CodeSourcery