From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [gdbserver] Uninitialized variable in linux-low.c:handle_extended_wait
Date: Fri, 11 Jul 2008 11:46:00 -0000 [thread overview]
Message-ID: <20080711114606.GA29668@caradoc.them.org> (raw)
In-Reply-To: <200807110337.m6B3b5FB004696@d12av02.megacenter.de.ibm.com>
On Fri, Jul 11, 2008 at 05:37:05AM +0200, Ulrich Weigand wrote:
> Note how "status" is used uninitialized if pull_pid_from_list
> returns true. In my case, this causes the "else" branch to be
> taken, which sets "stop_expected", which causes gdbserver to
> hang later on while waiting on the SIGSTOP which actually
> already arrived ...
>
> I'm not quite sure how to handle this -- I assume processes
> on the stopped_pids list should always be handled as if they
> got a SIGSTOP? The following patch fixes the hang for me ...
>
> Does this make sense?
Completely; your patch is OK. The code only triggers rarely, so I
just merged the version I wrote for linux-nat.c some time ago to
gdbserver. Apparently I did it wrong :-)
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-07-11 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 3:37 Ulrich Weigand
2008-07-11 11:46 ` Daniel Jacobowitz [this message]
2008-07-12 22:24 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711114606.GA29668@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox